Skip to content

flow-over-heated-plate: Add density and pressure to problem parameters#233

Merged
davidscn merged 2 commits intodevelopfrom
i_226
Aug 12, 2021
Merged

flow-over-heated-plate: Add density and pressure to problem parameters#233
davidscn merged 2 commits intodevelopfrom
i_226

Conversation

@BenjaminRodenberg
Copy link
Copy Markdown
Contributor

Related to #226. Currently the density is missing. This is no problem for OpenFOAM, where density defaults to 1kg/m^3 (see #226 (comment)), but for other solvers (e.g. ELMER), where the density must be specified by the user.

Open questions

@BenjaminRodenberg BenjaminRodenberg self-assigned this Aug 4, 2021
@davidscn
Copy link
Copy Markdown
Member

davidscn commented Aug 4, 2021

I was wondering why OpenFOAM does not need the parameter and ELMER does. Before merging here, it would be interesting to see whether a coupling with ELMER using the density parameter delivers the same results as other solver combinations do.

@BenjaminRodenberg
Copy link
Copy Markdown
Contributor Author

From my current understanding (see #226 (comment)), I would propose to provide a density for solid and fluid. For the solid the density is technically a "don't care", but

  • this is something we can and should verify (not sure if the Elmer adapter is already far enough for this kind of verification) and
  • I would still define a density (even if it is arbitrary), because this will avoid discussions in the future and make it easier for everybody who does not want to dig deep into the technical details.

For this PR this means:

  • Leave it as it is
  • Do some experiments with densities for more security

@davidscn
Copy link
Copy Markdown
Member

davidscn commented Aug 4, 2021

From my current understanding (see #226 (comment)), I would propose to provide a density for solid and fluid. For the solid the density is technically a "don't care", but

Agree

For this PR this means:

* Leave it as it is

* Do some experiments with densities for more security

I would vote for the second option because once we merge here nobody cares any more and we might painfully realize an issue later on.

@BenjaminRodenberg BenjaminRodenberg changed the title Flow-over-heated-plate: Add density to problem parameters Flow-over-heated-plate: Add density and pressure to problem parameters Aug 12, 2021
@BenjaminRodenberg
Copy link
Copy Markdown
Contributor Author

I just added the ambient pressure as an additional parameter. From my perspective this closes the system and allows us to derive the molar mass (if the solver requires it). See #226 (comment) for the derivation.

I think this PR is ready to merge. We could still perform some experiments, but since the derivation is quite simple I don't think that this is necessary anymore. @davidscn could you review and merge/comment?

@BenjaminRodenberg BenjaminRodenberg changed the title Flow-over-heated-plate: Add density and pressure to problem parameters flow-over-heated-plate: Add density and pressure to problem parameters Aug 12, 2021
@davidscn davidscn merged commit abefa99 into develop Aug 12, 2021
@davidscn davidscn deleted the i_226 branch August 12, 2021 06:46
@davidscn davidscn linked an issue Aug 12, 2021 that may be closed by this pull request
@MakisH MakisH added this to the v202104.2.0 milestone Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Required Problem Parameters for flow-over-heated-plate

3 participants