Skip to content

elastic-tube-1d: Remove unnecessary read statement#232

Merged
MakisH merged 2 commits intoprecice:developfrom
BenjaminRodenberg:i_231
Feb 1, 2022
Merged

elastic-tube-1d: Remove unnecessary read statement#232
MakisH merged 2 commits intoprecice:developfrom
BenjaminRodenberg:i_231

Conversation

@BenjaminRodenberg
Copy link
Copy Markdown
Contributor

@BenjaminRodenberg BenjaminRodenberg commented Jul 29, 2021

Closes #231

@BenjaminRodenberg BenjaminRodenberg self-assigned this Jul 29, 2021
@BenjaminRodenberg BenjaminRodenberg changed the base branch from master to develop July 29, 2021 08:15
@MakisH
Copy link
Copy Markdown
Member

MakisH commented Jul 29, 2021

Could you please rename the PR to clearly refer to elastic-tube-1d and to what it is changing? It would be easier to parse the PR list in the future.

@BenjaminRodenberg BenjaminRodenberg changed the title Remove unnecessary statement elastic-tube-1d: Remove unnecessary read statement Jul 29, 2021
@MakisH
Copy link
Copy Markdown
Member

MakisH commented Jul 29, 2021

Rebasing on develop should fix the failing "Check links" workflow.

@BenjaminRodenberg
Copy link
Copy Markdown
Contributor Author

BenjaminRodenberg commented Jul 30, 2021

This PR implements the following approach from #231 (comment):

initialize
read
while(ongoing){
  solve
  write
  advance
  read
}

@BenjaminRodenberg BenjaminRodenberg mentioned this pull request Jul 30, 2021
Closed
@uekerman
Copy link
Copy Markdown
Member

uekerman commented Jul 31, 2021

Don't forget the changelog entry

@MakisH MakisH merged commit 9750de5 into precice:develop Feb 1, 2022
@MakisH MakisH added this to the v202104.2.0 milestone Feb 9, 2022
@BenjaminRodenberg BenjaminRodenberg deleted the i_231 branch November 22, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MakisH MakisH MakisH approved these changes

@KyleDavisSA KyleDavisSA Awaiting requested review from KyleDavisSA

Assignees

@BenjaminRodenberg BenjaminRodenberg

Labels

bug

Projects

None yet

Milestone

v202202.0

Development

Successfully merging this pull request may close these issues.

elastic-tube-1d: Unnecessary readBlockScalarData

3 participants

@BenjaminRodenberg @MakisH @uekerman