elastic-tube-1d: Unnecessary readBlockScalarData #231
Description
The following readBlockScalarData statements looks wrong and is inconsistent with the python version of the 1d tube:
tutorials/elastic-tube-1d/fluid-cpp/src/FluidSolver.cpp
Lines 104 to 106 in 6d90ae3
Compared to the original code (see https://github.com/precice/elastictube1d/blob/master/fluid-cpp/FluidSolver.cpp) this statement has been added. Is there a specific reason?
I did some experiments related to this change and will document them here, since this might be helpful for precice/precice#1036:
| commit | comment | fluid-cpp + solid-cpp remove statement above (fa75a39) |
fluid-cpp + solid-cpp keep statement above (46ce8ab) |
fluid-python + solid-python (46ce8ab) |
|---|---|---|---|---|
| precice/precice@3ff0899 | pre precice/precice#1004 | ✔️ | ✔️ | ✔️ |
| precice/precice@54707b3 | current state precice/precice#1036 | ✔️ | ✔️ | ✔️ |
| precice/precice@40eca9d | current state precice:develop |
❌ | ❌ | ❌ |
| precice/precice@c9c90b2 | merge precice:develop into precice/precice#1036 |
✔️ | ✔️ | ✔️ |
✔️ -> elastic-tube-1d works as expected
❌ -> elastic-tube-1d breaks as described in precice/precice#1032