Merged
Conversation
BenjaminRodenberg
suggested changes
Feb 7, 2024
Contributor
BenjaminRodenberg
left a comment
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
I think the pre-release workflow is still a bit strange: We should do the pre-release from the same branch and commit that should be used as a basis for the stable release in the future. Remember: We want to test the workflow of the actual release and should , therefore, stay as close to the actual release as possible.
I think some tweaking of 4. is necessary.
Co-authored-by: Benjamin Rodenberg <[email protected]>
Co-authored-by: Benjamin Rodenberg <[email protected]>
Co-authored-by: Benjamin Rodenberg <[email protected]>
…ings into update-release-guide
Member
Author
|
@BenjaminRodenberg I reworded the pre-release part. Can you have a look once more? |
Contributor
|
Needs merge, but looks good to me 👍 |
BenjaminRodenberg
approved these changes
Feb 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the release of v3.0.0.0, I noticed that some instructions in the release guide are not easy to follow and a bit confusing. I reordered some things and also moved the pre-releasing points into their own section.
For reviewing, it would make sense if one directly reads the new release guide and tries to gauge the flow of the document.