Conversation
BenjaminRodenberg
added
breaking change
|
Can we sync this with the latest develop to ensure that when we plan to merge this we would not have excessive conflicts? |
Done. |
|
Since precice/precice#1366 has now been merged upstream, we can also start moving the bindings to v3.0.0. @BenjaminRodenberg should we start by merging this PR? I am open to suggestions if you already have some order of doing things in mind. |
|
As far as my plans are concerned this PR should be ready to merge. I think another round of manual testing does not harm. @IshaanDesai Feel free to play around with the current develop state of preCICE and this PR. I think this is a good step to understand the upcoming changes in preCICE as well. If after testing everything looks good, you can just merge. If you find something that is not documented or broken, this is a good thing to fix before merging. |
IshaanDesai
left a comment
IshaanDesai
left a comment
There was a problem hiding this comment.
I did some manual testing and everything seems to be in order for now. If something does break, we can fix it post merge.
2 participants
Ensures compatibility to preCICE v3.0.0.
This PR should work with https://github.com/precice/precice/tree/develop-v3.0.0.