Skip to content

Specify guidelines for meshes in multi-coupling#216

Merged
MakisH merged 1 commit intomasterfrom
mc-mesh-names
Nov 14, 2022
Merged

Specify guidelines for meshes in multi-coupling#216
MakisH merged 1 commit intomasterfrom
mc-mesh-names

Conversation

@MakisH
Copy link
Copy Markdown
Member

@MakisH MakisH commented Nov 13, 2022

Documents the naming conventions documented in precice/tutorials#303, adding:

  • Mesh names of participants with multiple interfaces contain the interface in the mesh name, e.g. Fluid-Upstream-Mesh. For meshes on which it is important to distinguish between face centers and face nodes, the modifier comes at the end, e.g. Fluid-Upstream-Mesh-Centers.

I believe that Fluid-Upstream-Centers-Mesh would make more sense, but this is closer to our current practice.

@MakisH MakisH added the content Content-only issues label Nov 13, 2022
@MakisH MakisH self-assigned this Nov 13, 2022
Copy link
Copy Markdown
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MakisH MakisH marked this pull request as ready for review November 14, 2022 16:52
@MakisH MakisH merged commit 04b01f0 into master Nov 14, 2022
@MakisH MakisH deleted the mc-mesh-names branch November 14, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content Content-only issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants