Update WR documentation for serial coupling#174
Closed
BenjaminRodenberg wants to merge 5 commits intoprecice-v3from
Closed
Update WR documentation for serial coupling#174BenjaminRodenberg wants to merge 5 commits intoprecice-v3from
BenjaminRodenberg wants to merge 5 commits intoprecice-v3from
Conversation
BenjaminRodenberg
added
the
documentation
uekerman
reviewed
Jun 16, 2022
Comment on lines
+97
to
+101
| ## Initialize Data | ||
|
|
||
| * When using waveform iteration both participants can initialize data, even when serial implicit coupling is used. | ||
| * Reason for this: Initialized data is used at the beginning of the window. First write data at the end of the window. This means: Also first participant can initialize data that will be used by second participant at the beginning of the window. The the same time there is already data available at the end of the window in the first iteration of a serial implict coupling scheme. | ||
| * If no initial data is provided, the data at the beginning of the window is **always** implicitly set to zero and there is no possibility to change this. |
Member
There was a problem hiding this comment.
Suggested change
| ## Initialize Data | |
| * When using waveform iteration both participants can initialize data, even when serial implicit coupling is used. | |
| * Reason for this: Initialized data is used at the beginning of the window. First write data at the end of the window. This means: Also first participant can initialize data that will be used by second participant at the beginning of the window. The the same time there is already data available at the end of the window in the first iteration of a serial implict coupling scheme. | |
| * If no initial data is provided, the data at the beginning of the window is **always** implicitly set to zero and there is no possibility to change this. | |
| ## Initialize Data | |
| * When using waveform iteration both participants can initialize data, even when serial implicit coupling is used. | |
| * Reason for this: Initialized data is used at the beginning of the window. First write data at the end of the window. This means: Also first participant can initialize data that will be used by second participant at the beginning of the window. The the same time there is already data available at the end of the window in the first iteration of a serial implict coupling scheme. | |
| * If no initial data is provided, the data at the beginning of the window is **always** implicitly set to zero and there is no possibility to change this. |
Suggested change
| ## Initialize Data | |
| * When using waveform iteration both participants can initialize data, even when serial implicit coupling is used. | |
| * Reason for this: Initialized data is used at the beginning of the window. First write data at the end of the window. This means: Also first participant can initialize data that will be used by second participant at the beginning of the window. The the same time there is already data available at the end of the window in the first iteration of a serial implict coupling scheme. | |
| * If no initial data is provided, the data at the beginning of the window is **always** implicitly set to zero and there is no possibility to change this. | |
| ## Initialize data | |
| * When using waveform iteration, both participants can initialize data, even when serial-implicit coupling is used. | |
| * Reason for this: Initialized data is used at the beginning of the window. First write data at the end of the window. Thus, the first participant can initialize data that is used by the second participant at the beginning of the window. | |
| * If no initial data is provided, the data at the beginning of the window is **always** implicitly set to zero. |
The sentence "The the same time there is already data available ...", I did not understand.
Could we add figures here? 😁
Contributor
Author
There was a problem hiding this comment.
I will try to come up with a nice figure 👍
Co-authored-by: Benjamin Uekermann <[email protected]>
Contributor
Author
|
Since we decided to removed |
9 tasks
Contributor
Author
|
I added an issue on the topic of data initialization: precice/precice#1367 |
Contributor
Author
|
I also updated the documentation on data initialization: #186 |
BenjaminRodenberg
added
the
breaking change
uekerman
changed the title
Contributor
Author
|
Closing this PR, because most changes are on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides documentation related to the feature precice/precice#1029.
Todo