Documentation for waveform interpolation#109
Conversation
BenjaminRodenberg
added
documentation
uekerman
left a comment
uekerman
left a comment
There was a problem hiding this comment.
I think it was a good step to write this down. We clearly see where there are still open problems.
Before merging at some point, also somebody not familiar with the new functionality should review this.
Co-authored-by: Benjamin Uekermann <[email protected]>
Co-authored-by: Benjamin Uekermann <[email protected]>
uekerman
left a comment
uekerman
left a comment
There was a problem hiding this comment.
Looking good 👍
Still a few tweaks, but should all be easy.
Then, I would suggest that somebody not so familiar with your PRs looks over this.
Co-authored-by: Benjamin Uekermann <[email protected]>
uekerman
left a comment
uekerman
left a comment
There was a problem hiding this comment.
Minor language tweaks, otherwise good to go from my side.
Could still be helpful to let a non-expert read over this.
Co-authored-by: Benjamin Uekermann <[email protected]>
Co-authored-by: Benjamin Uekermann <[email protected]>
Co-authored-by: Benjamin Uekermann <[email protected]>
…recice.github.io into BenjaminRodenberg-waveform-doc
|
I just had a quick read as a naive reader, and I wondered how we reconcile order of the waveform and numbers of subcycles. If I want a 2nd order waveform but perform 10 steps, how will the polynom be built ? Least-squares fit ? Arbirtray selection of 3 points ? |
Currently the implementation is very limited here. There is basically only the possibility to create a linear interpolant from the first and last sample in the window. If you are subcycling, all samples between will be ignored (they are not even communicated). I'm describing the current restrictions and the rough plan here: precice/precice#1171. |
3 participants
Provides documentation for new feature in precice/precice#1029.