Support building as a static library#973
Closed
fsimonis wants to merge 6 commits intoprecice:developfrom
Closed
Conversation
Member
Author
|
I am closing this as this is non-trivial and not requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes of this PR
This PR adds support for CMake to build preCICE as a static library.
The main change is a custom
preciceConfig.cmake, which is based on the auto-generated one.Motivation and additional information
Building CMake as a static library and then using it via the
preciceConfig.cmakewas not properly supported.The auto-generated config lists all header-only/interface libraries as link dependencies. This is required as they themself may depend on a static/shared library.
Thus, this required to find dependencies such as jsoncpp, prettyprint, Eigen, NumPy etc.
Related to #801, #677
Author's checklist
docs/changelog/if there are noteworthy changes.tools/formatting/check-formatand everything is formatted correctly.Reviewers' checklist