Skip to content

PR draft MATLAB bindings#580

Merged
BenjaminRodenberg merged 10 commits intodraft_MATLAB_bindingsfrom
unknown repository
Dec 20, 2019
Merged

PR draft MATLAB bindings#580
BenjaminRodenberg merged 10 commits intodraft_MATLAB_bindingsfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Nov 27, 2019 •
edited by BenjaminRodenberg
Loading

MATLAB bindings with their documentation, including a small tutorial.

The bindings are working right now, however there are some things to do before merging:

@ghost ghost added the enhancement A new feature, a new functionality of preCICE (from user perspective) label Nov 27, 2019
@ghost ghost requested a review from BenjaminRodenberg November 27, 2019 09:55
@ghost ghost self-assigned this Nov 27, 2019
@ghost ghost mentioned this pull request Nov 27, 2019
Closed
BenjaminRodenberg
BenjaminRodenberg suggested changes Dec 6, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@BenjaminRodenberg BenjaminRodenberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I managed to get the bindings running on my machine following the instructions provided in the README.md. I tested the installation by running the solverdummy and the provided tutorial. This procedure looks good to me.

I left some comments:

  1. Regarding arguments accepted by the constructor SolverInterface.
  2. Regarding the inSize argument that could be spared in many functions.

BenjaminRodenberg
BenjaminRodenberg approved these changes Dec 20, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good now. Ready to be merged. @fsimonis do we have to take care of something due to the reformatting?

@BenjaminRodenberg BenjaminRodenberg changed the base branch from develop to draft_MATLAB_bindings December 20, 2019 12:27
@BenjaminRodenberg
Copy link
Copy Markdown
Contributor

BenjaminRodenberg commented Dec 20, 2019

I changed the branch that we are merging into to https://github.com/precice/precice/tree/draft_MATLAB_bindings. We do not want to merge this contribution into develop, since we have already decided that the MATLAB bindings should be provided in https://github.com/precice/matlab-bindings.

I will merge this PR now, then we can move the code to https://github.com/precice/matlab-bindings and refer to this PR in the initial commit on https://github.com/precice/matlab-bindings.

@BenjaminRodenberg BenjaminRodenberg merged commit 4aca8d3 into precice:draft_MATLAB_bindings Dec 20, 2019
@BenjaminRodenberg BenjaminRodenberg mentioned this pull request Dec 20, 2019
Merged
BenjaminRodenberg added a commit to precice/matlab-bindings that referenced this pull request Dec 20, 2019
@BenjaminRodenberg @Dominanz
Move matlab-bindings to this repository (#5)
a61eba1 
Moved from https://github.com/precice/precice/tree/draft_MATLAB_bindings.

Main contributions contained in this PR:

* precice/precice#494
* precice/precice#580

Co-authored-by: Dominik <[email protected]>
Co-authored-by: Gilberto Lem <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement A new feature, a new functionality of preCICE (from user perspective)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@BenjaminRodenberg