Use const double& for writeScalarData#530
Closed
BenjaminRodenberg wants to merge 2 commits intodevelopfrom
Closed
Conversation
BenjaminRodenberg
added a commit
to Dominanz/precice
that referenced
this pull request
Sep 26, 2019
…, the will be introduced via precice#530
Member
|
@BenjaminRueth Can you explain the problem? Passing a single double via const reference is pointless and changing it is backwards-compatible. |
Contributor
Author
|
@fsimonis if it is backwards compatible and passing a double value via a const reference is pointless, everything is fine as it is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change was introduced in be65dce. I first assumed that it was just forgotten in #348. However, in e480aef it was intentionally removed.
In any case we should avoid reintroducing this change via #494. And, if we want to introduce the change, introduce it independently. @fsimonis can you enlighten me?