Skip to content

Add export data tests#2147

Merged
fsimonis merged 2 commits intoprecice:developfrom
fsimonis:add-export-data-tests
Nov 28, 2024
Merged

Add export data tests#2147
fsimonis merged 2 commits intoprecice:developfrom
fsimonis:add-export-data-tests

Conversation

@fsimonis
Copy link
Copy Markdown
Member

Main changes of this PR

This PR adds simple exporter tests for scalar, vectorial and missing data.

Motivation and additional information

This would have prevented #2131

Author's checklist

  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I added a changelog file with make changelog if there are user-observable changes since the last release.
  • I added a test to cover the proposed changes in our test suite.
  • For breaking changes: I documented the changes in the appropriate porting guide.
  • I stuck to C++17 features.
  • I stuck to CMake version 3.22.1.
  • I squashed / am about to squash all commits that should be seen as one.

@fsimonis fsimonis requested a review from uekerman November 28, 2024 09:13
@fsimonis fsimonis removed their assignment Nov 28, 2024
@fsimonis fsimonis added bug preCICE does not behave the way we want and we should look into it (and fix it if possible) and removed bug preCICE does not behave the way we want and we should look into it (and fix it if possible) labels Nov 28, 2024
@fsimonis fsimonis added this to the Version 3.2.0 milestone Nov 28, 2024
@fsimonis fsimonis mentioned this pull request Nov 28, 2024
7 tasks
@fsimonis fsimonis force-pushed the add-export-data-tests branch from 2b34797 to e8c16b3 Compare November 28, 2024 13:00
Copy link
Copy Markdown
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good.
I had an integration test in mind to exactly reproduce the problem we ran into.

@fsimonis
Copy link
Copy Markdown
Member Author

@uekerman An integration test is a bit overkill if we exactly know the root cause of the issue:

https://github.com/precice/precice/pull/2147/files#diff-593d66124caf2b00b644579498b978c9a52e76055a2bacafab25cc0cd4c0b3acR50-R61

@fsimonis fsimonis merged commit b071675 into precice:develop Nov 28, 2024
@fsimonis fsimonis deleted the add-export-data-tests branch November 28, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants