Skip non-existent data in exporter#2132
Merged
fsimonis merged 3 commits intoprecice:developfrom Feb 22, 2025
Merged
Conversation
Member
|
Let's please add an integration test here. |
Member
Author
|
I just realized that the exporter tests don't define data at all. So it's all mesh-only. |
Member
|
But an integration should be easy. Clear what I mean? If not, I could also add one. |
Member
Author
|
@uekerman Yes clear, but this should be added to develop before this PR. |
Member
Author
This was referenced Jan 27, 2025
fsimonis
added
the
bug
Member
|
@fsimonis nothing to wait here anymore from the system tests side. We have figured out the rest of the regressions. Unfortunately, I cannot trigger the system tests on this PR, as the branch is on a fork and we currently don't support that. Just merge when the usual criteria are fulfilled, and I will update the reference results later, if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes of this PR
This PR skips non-existent data when exporting.
Motivation and additional information
Non-exisiting data (received mesh, non-exchanged data) was exported as 0, even though it doesn't really exist.
It is now omitted from the export.
@MakisH this breaks reference results of the system tests.
Author's checklist
pre-commithook to prevent dirty commits and usedpre-commit run --allto format old commits.make changelogif there are user-observable changes since the last release.