Skip to content

Use time::Storage for sending and receiving data#1504

Closed
BenjaminRodenberg wants to merge 105 commits intoprecice:developfrom
BenjaminRodenberg:use-storage-in-coupling-data
Closed

Use time::Storage for sending and receiving data#1504
BenjaminRodenberg wants to merge 105 commits intoprecice:developfrom
BenjaminRodenberg:use-storage-in-coupling-data

Conversation

@BenjaminRodenberg
Copy link
Copy Markdown
Contributor

@BenjaminRodenberg BenjaminRodenberg commented Dec 4, 2022 •
edited
Loading

Main changes of this PR

Uses time::Storage to store sent and received data.

Motivation and additional information

Author's checklist

Reviewers' checklist

  • Does the changelog entry make sense? Is it formatted correctly?
  • Do you understand the code changes?

@BenjaminRodenberg BenjaminRodenberg added the maintainability Working on this will make our lives easier in the long run as preCICE gets easier to maintain. label Dec 4, 2022
@BenjaminRodenberg BenjaminRodenberg self-assigned this Dec 4, 2022
@BenjaminRodenberg
Copy link
Copy Markdown
Contributor Author

BenjaminRodenberg commented Dec 4, 2022

Currently, some tests are not working. But the basic functionality is fine.

@BenjaminRodenberg BenjaminRodenberg mentioned this pull request Dec 4, 2022
Closed
17 tasks
BenjaminRodenberg
BenjaminRodenberg commented Dec 4, 2022
View reviewed changes
Comment thread src/precice/impl/SolverInterfaceImpl.cpp Outdated
Comment thread src/precice/impl/SolverInterfaceImpl.hpp Outdated
Comment thread src/time/Storage.cpp Outdated
@fsimonis
Copy link
Copy Markdown
Member

fsimonis commented Dec 5, 2022

Could you try to rebase this PR on #1462 I would prefer to merge it swiftly.

@BenjaminRodenberg
Copy link
Copy Markdown
Contributor Author

BenjaminRodenberg commented Dec 7, 2022

Could you try to rebase this PR on #1462 I would prefer to merge it swiftly.

I will try to synchronize this PR with develop as soon as I figured out what's going wrong with the Quasi-Newton Test. I guess I will need some more unit tests here first.

@BenjaminRodenberg
Copy link
Copy Markdown
Contributor Author

BenjaminRodenberg commented Dec 7, 2022

I merged #1507 into this PR, but the new unit tests did not give me any new insights regarding the failure of parallel coupling + QN

uekerman
uekerman reviewed Apr 8, 2023
View reviewed changes
Comment thread src/precice/impl/SolverInterfaceImpl.cpp
}

void SolverInterfaceImpl::mapReadData()
void SolverInterfaceImpl::mapReadDataAndPerformReadAction(std::vector<double> receiveTimes)
Copy link
Copy Markdown
Member

@uekerman uekerman Apr 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, this function (name) is overkill. But let's re-evaluate once we have a symmetric treatment of read and write.

@BenjaminRodenberg
Copy link
Copy Markdown
Contributor Author

BenjaminRodenberg commented Apr 17, 2023

To give a short summary on the status and next steps of this PR:

Events have been simplified in #1614. Our next goal is to reach a state where read and write data is more symmetric. For this, we need to find a conclusion in #1612.

@BenjaminRodenberg BenjaminRodenberg mentioned this pull request May 4, 2023
Merged
10 tasks
@BenjaminRodenberg
Copy link
Copy Markdown
Contributor Author

BenjaminRodenberg commented May 4, 2023

Replaced by #1639

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uekerman uekerman uekerman requested changes

@fsimonis fsimonis fsimonis left review comments

Assignees

@BenjaminRodenberg BenjaminRodenberg

Labels

maintainability Working on this will make our lives easier in the long run as preCICE gets easier to maintain.

Projects

None yet

Milestone

Version 3.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@BenjaminRodenberg @fsimonis @uekerman