Merged
Conversation
17 tasks
Contributor
Author
|
@fsimonis would you mind taking a look at the CI pipeline? It looks to me like increasing the timeouts cleared some caching somewhere and broke the macOS pipeline. Not sure what happened, but I created this PR to isolate the breaking pipeline from the big PR #1414, where I actually need this change. |
BenjaminRodenberg
force-pushed
the
develop-v3.0.0
branch
from
49e7c2a to
565d8ff
Compare
precice.cplscheme and precice.integration.Serial take longer with new tests introduced in #1414
BenjaminRodenberg
force-pushed
the
increase-timeouts
branch
from
d028318 to
4446fe0
Compare
Member
|
The macos pipeline occasionally breaks and just needs a rerun. Instead of increasing timeouts in general, I would prefer to increase timeouts as necessary. Could you try switching the cplscheme tests from short to long timeouts in the cmake/Ctest file? |
fsimonis
reviewed
Nov 3, 2022
Co-authored-by: Frédéric Simonis <[email protected]>
fsimonis
approved these changes
Nov 3, 2022
BenjaminRodenberg
added a commit
that referenced
this pull request
Nov 4, 2022
* Increase timeouts for precice.cplscheme and precice.integration.Serial, because they will take longer with new tests introduced in #1414 Co-authored-by: Frédéric Simonis <[email protected]>
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes of this PR
Timouts for tests are increased, because changes in #1414 make this necessary.
Motivation and additional information
precice.cplscheme and precice.integration.Serial take longer with new tests introduced in #1414
Author's checklist
pre-commithook to prevent dirty commits and usedpre-commit run --allto format old commits.make changelogif there are user-observable changes since the last release.Reviewers' checklist