Remove incorrect warning for waveform order zero and serial coupling schemes#1455
Merged
BenjaminRodenberg merged 2 commits intoprecice:develop-v3.0.0from Nov 4, 2022
Conversation
17 tasks
49e7c2a to
565d8ff
Compare
d71d259 to
e01ce59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes of this PR
Removes warning that tells user to not initialize data of second participant in serial coupling, if waveform order is zero. Initialization actually becomes reasonable in this case, if the user wants to sample at the starting time (we cannot know whether the user will sample or not, because the sampling happens over the API).
This PR also removes the warning to avoid the test
Integration/Serial/Time/Implicit/SerialCoupling/ReadWriteScalarDataWithWaveformSamplingZeroto trigger the warning. The test is correct and should not trigger any warning that suggests a change (because this will lead to a failure of the test).Motivation and additional information
This change is motivated by #1422. See this change in the test: 270cc08#diff-52e93df8fe0311c9dcda9c30ccdb04ac3fd7d92fc5f7576ae6b261a40e23fb83L81-R81: At the beginning of the window we now get the data from the last window or initial data, even for zeroth order waveforms. This makes data initialization relevant for all coupling schemes and participants, if a user wants to sample the function at the beginning of the simulation time.
See also comments under #1414 (comment) for further discussion.
Author's checklist
pre-commithook to prevent dirty commits and usedpre-commit run --allto format old commits.make changelogif there are user-observable changes since the last release.Reviewers' checklist