Skip to content

Remove incorrect warning for waveform order zero and serial coupling schemes#1455

Merged
BenjaminRodenberg merged 2 commits intoprecice:develop-v3.0.0from
BenjaminRodenberg:remove-incorrect-warning
Nov 4, 2022
Merged

Remove incorrect warning for waveform order zero and serial coupling schemes#1455
BenjaminRodenberg merged 2 commits intoprecice:develop-v3.0.0from
BenjaminRodenberg:remove-incorrect-warning

Conversation

@BenjaminRodenberg
Copy link
Copy Markdown
Contributor

Main changes of this PR

Removes warning that tells user to not initialize data of second participant in serial coupling, if waveform order is zero. Initialization actually becomes reasonable in this case, if the user wants to sample at the starting time (we cannot know whether the user will sample or not, because the sampling happens over the API).

This PR also removes the warning to avoid the test Integration/Serial/Time/Implicit/SerialCoupling/ReadWriteScalarDataWithWaveformSamplingZero to trigger the warning. The test is correct and should not trigger any warning that suggests a change (because this will lead to a failure of the test).

Motivation and additional information

This change is motivated by #1422. See this change in the test: 270cc08#diff-52e93df8fe0311c9dcda9c30ccdb04ac3fd7d92fc5f7576ae6b261a40e23fb83L81-R81: At the beginning of the window we now get the data from the last window or initial data, even for zeroth order waveforms. This makes data initialization relevant for all coupling schemes and participants, if a user wants to sample the function at the beginning of the simulation time.

See also comments under #1414 (comment) for further discussion.

Author's checklist

  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I added a changelog file with make changelog if there are user-observable changes since the last release.
  • I added a test to cover the proposed changes in our test suite. (not relevant)
  • I sticked to C++17 features.
  • I sticked to CMake version 3.16.3.
  • I squashed / am about to squash all commits that should be seen as one.

Reviewers' checklist

  • Does the changelog entry make sense? Is it formatted correctly?
  • Do you understand the code changes?

@BenjaminRodenberg BenjaminRodenberg added the bug preCICE does not behave the way we want and we should look into it (and fix it if possible) label Oct 31, 2022
@BenjaminRodenberg BenjaminRodenberg self-assigned this Oct 31, 2022
@BenjaminRodenberg BenjaminRodenberg changed the title Remove incorrect warning Remove incorrect warning for waveform order zero and serial coupling schemes Oct 31, 2022
@BenjaminRodenberg BenjaminRodenberg changed the base branch from develop to develop-v3.0.0 October 31, 2022 16:44
@BenjaminRodenberg BenjaminRodenberg added this to the Version 3.0.0 milestone Nov 2, 2022
Copy link
Copy Markdown
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@BenjaminRodenberg BenjaminRodenberg merged commit 721976f into precice:develop-v3.0.0 Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug preCICE does not behave the way we want and we should look into it (and fix it if possible)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants