Support waveform interpolation in read for multi-coupling#1445
Merged
BenjaminRodenberg merged 2 commits intodevelop-v3.0.0from Nov 2, 2022
Merged
Support waveform interpolation in read for multi-coupling#1445BenjaminRodenberg merged 2 commits intodevelop-v3.0.0from
BenjaminRodenberg merged 2 commits intodevelop-v3.0.0from
Conversation
Member
|
I briefly looked at 81ef7be#diff-3d1568b390afb81c70e7f889b5c7cf4067647f140b9f9d1d2e13410ae23ce4a1 (Add test and allow waveforms in multi-coupling) |
Contributor
Author
Done 👍 @uekerman can you check again? |
17 tasks
Contributor
Author
|
@uekerman thanks for the review! I will squash&merge this PR as soon as the tests are done. |
BenjaminRodenberg
force-pushed
the
develop-v3.0.0
branch
from
49e7c2a to
565d8ff
Compare
BenjaminRodenberg
force-pushed
the
support-waveform-read-multi-coupling
branch
from
bc40acb to
b4324a1
Compare
BenjaminRodenberg
added a commit
that referenced
this pull request
Nov 4, 2022
* Add test and allow waveforms in multi-coupling.
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes of this PR
Also allow to use waveforms with multi-coupling and add tests.
Motivation and additional information
In #1352 multi-coupling was still forbidden. This PR adds a test for multi-coupling and supports it.
Bigger picture: In #1171 multi coupling becomes more complicated, because different participants might write data from different meshes in time that the receiving solver has to handle. We should first get the simple multi coupling without subcycling working before approaching this bigger task.
Author's checklist
pre-commithook to prevent dirty commits and usedpre-commit run --allto format old commits.make changelogif there are user-observable changes since the last release.Reviewers' checklist