Skip to content

Improve encapsulation of CouplingData#1442

Merged
BenjaminRodenberg merged 1 commit intoprecice:develop-v3.0.0from
BenjaminRodenberg:improve-coupling-data-encapsulation
Sep 28, 2022
Merged

Improve encapsulation of CouplingData#1442
BenjaminRodenberg merged 1 commit intoprecice:develop-v3.0.0from
BenjaminRodenberg:improve-coupling-data-encapsulation

Conversation

@BenjaminRodenberg
Copy link
Copy Markdown
Contributor

@BenjaminRodenberg BenjaminRodenberg commented Sep 28, 2022

Main changes of this PR

Introduce CouplingData::getSize and CouplingData::getPreviousIterationSize for better encapsulation.

Motivation and additional information

Less calls to CouplingData::values(), when it is not needed.

Author's checklist

  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I added a changelog file with make changelog if there are user-observable changes since the last release.
  • I added a test to cover the proposed changes in our test suite.
  • I sticked to C++17 features.
  • I sticked to CMake version 3.16.3.
  • I squashed / am about to squash all commits that should be seen as one.

Reviewers' checklist

  • Does the changelog entry make sense? Is it formatted correctly?
  • Do you understand the code changes?

@BenjaminRodenberg BenjaminRodenberg added the maintainability Working on this will make our lives easier in the long run as preCICE gets easier to maintain. label Sep 28, 2022
@BenjaminRodenberg BenjaminRodenberg self-assigned this Sep 28, 2022
@BenjaminRodenberg BenjaminRodenberg merged commit 7b44428 into precice:develop-v3.0.0 Sep 28, 2022
BenjaminRodenberg added a commit that referenced this pull request Nov 2, 2022
BenjaminRodenberg added a commit that referenced this pull request Nov 4, 2022
@BenjaminRodenberg BenjaminRodenberg added this to the Version 3.0.0 milestone Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainability Working on this will make our lives easier in the long run as preCICE gets easier to maintain.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants