Simplify signature of actions and remove ScaleByDtAction#1403
Merged
BenjaminRodenberg merged 22 commits intoprecice:develop-v3.0.0from Aug 8, 2022
Merged
Conversation
* Remove mapReadDataTo and mapWriteDataFrom. * Remove tests using removed API.
* Merge initialize and initializeData in SolverInterfaceImpl. * Merge initialize and initializeData in CouplingScheme. * Update tests correspondingly * Allow to check actions before initialize, especially checking whether initial data has to be written * Check for sending and receiving of initial data during coupling scheme configuration * Code simplification w.r.t waveform. * Use dt=0.0 in actions in initialize. Co-authored-by: Benjamin Uekermann <[email protected]> Co-authored-by: Frédéric Simonis <[email protected]>
…recice#1352) * Get tests and configs for serial implicit waveform interpolation from precice#1029. * Differentiate between received initial data and data (from advance). * Split data communication for SerialCouplingScheme and store initial data in waveform. * Move common functionality of serial and parallel coupling scheme into BiCouplingScheme. Co-authored-by: Benjamin Uekermann <[email protected]>
* Add test Integration/Serial/InitializeData/ImplicitBoth where both participants initialize. * Allow initialize=true for both participants in serial-implicit coupling scheme. * Raise warning, if first participant in serial coupling scheme initializes data with waveform order zero. * Remove check for write data, because participant does not know about waveform order. Co-authored-by: Benjamin Uekermann <[email protected]>
* Removes ScaleByDtAction precice#934 * Remove arguments timeStepSize, computedTimeWindowPart, timeWindowSize, because there is no clear use case precice#1358
* Remove mapReadDataTo and mapWriteDataFrom. * Remove tests using removed API.
* Merge initialize and initializeData in SolverInterfaceImpl. * Merge initialize and initializeData in CouplingScheme. * Update tests correspondingly * Allow to check actions before initialize, especially checking whether initial data has to be written * Check for sending and receiving of initial data during coupling scheme configuration * Code simplification w.r.t waveform. * Use dt=0.0 in actions in initialize. Co-authored-by: Benjamin Uekermann <[email protected]> Co-authored-by: Frédéric Simonis <[email protected]>
…recice#1352) * Get tests and configs for serial implicit waveform interpolation from precice#1029. * Differentiate between received initial data and data (from advance). * Split data communication for SerialCouplingScheme and store initial data in waveform. * Move common functionality of serial and parallel coupling scheme into BiCouplingScheme. Co-authored-by: Benjamin Uekermann <[email protected]>
* Add test Integration/Serial/InitializeData/ImplicitBoth where both participants initialize. * Allow initialize=true for both participants in serial-implicit coupling scheme. * Raise warning, if first participant in serial coupling scheme initializes data with waveform order zero. * Remove check for write data, because participant does not know about waveform order. Co-authored-by: Benjamin Uekermann <[email protected]>
105c3ef to
436fcd5
Compare
436fcd5 to
6a5f5a3
Compare
Co-authored-by: Benjamin Uekermann <[email protected]>
BenjaminRodenberg
added a commit
that referenced
this pull request
Aug 11, 2022
Co-authored-by: Benjamin Uekermann <[email protected]>
BenjaminRodenberg
added a commit
that referenced
this pull request
Aug 22, 2022
Co-authored-by: Benjamin Uekermann <[email protected]>
BenjaminRodenberg
added a commit
that referenced
this pull request
Aug 22, 2022
Co-authored-by: Benjamin Uekermann <[email protected]>
BenjaminRodenberg
added a commit
that referenced
this pull request
Sep 15, 2022
Co-authored-by: Benjamin Uekermann <[email protected]>
BenjaminRodenberg
added a commit
that referenced
this pull request
Nov 2, 2022
Co-authored-by: Benjamin Uekermann <[email protected]>
BenjaminRodenberg
added a commit
that referenced
this pull request
Nov 4, 2022
Co-authored-by: Benjamin Uekermann <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes of this PR
Closes #1358 and closes #934.
Motivation and additional information
See #1358.
Author's checklist
make changelogif there are user-observable changes since the last release.make formatto ensure everything is formatted correctly.Reviewers' checklist