Skip to content

Simplify signature of actions and remove ScaleByDtAction#1403

Merged
BenjaminRodenberg merged 22 commits intoprecice:develop-v3.0.0from
BenjaminRodenberg:1358-simplify-signature-of-actions
Aug 8, 2022
Merged

Simplify signature of actions and remove ScaleByDtAction#1403
BenjaminRodenberg merged 22 commits intoprecice:develop-v3.0.0from
BenjaminRodenberg:1358-simplify-signature-of-actions

Conversation

@BenjaminRodenberg
Copy link
Copy Markdown
Contributor

@BenjaminRodenberg BenjaminRodenberg commented Aug 5, 2022

Main changes of this PR

Closes #1358 and closes #934.

Motivation and additional information

See #1358.

Author's checklist

  • I added a changelog file with make changelog if there are user-observable changes since the last release.
  • I ran make format to ensure everything is formatted correctly.
  • I sticked to C++14 features.
  • I sticked to CMake version 3.16.3.
  • I squashed / am about to squash all commits that should be seen as one.

Reviewers' checklist

  • Does the changelog entry make sense? Is it formatted correctly?
  • Do you understand the code changes?

BenjaminRodenberg and others added 7 commits July 29, 2022 08:47
* Remove mapReadDataTo and mapWriteDataFrom.
* Remove tests using removed API.
* Merge initialize and initializeData in SolverInterfaceImpl.
* Merge initialize and initializeData in CouplingScheme.
* Update tests correspondingly
* Allow to check actions before initialize, especially checking whether initial data has to be written
* Check for sending and receiving of initial data during coupling scheme configuration
* Code simplification w.r.t waveform.
* Use dt=0.0 in actions in initialize.

Co-authored-by: Benjamin Uekermann <[email protected]>
Co-authored-by: Frédéric Simonis <[email protected]>
…recice#1352)

* Get tests and configs for serial implicit waveform interpolation from precice#1029.
* Differentiate between received initial data and data (from advance).
* Split data communication for SerialCouplingScheme and store initial data in waveform.
* Move common functionality of serial and parallel coupling scheme into BiCouplingScheme.

Co-authored-by: Benjamin Uekermann <[email protected]>
* Add test Integration/Serial/InitializeData/ImplicitBoth where both participants initialize.
* Allow initialize=true for both participants in serial-implicit coupling scheme.
* Raise warning, if first participant in serial coupling scheme initializes data with waveform order zero.
* Remove check for write data, because participant does not know about waveform order.

Co-authored-by: Benjamin Uekermann <[email protected]>
* Removes ScaleByDtAction precice#934
* Remove arguments timeStepSize, computedTimeWindowPart, timeWindowSize,
because there is no clear use case precice#1358
@BenjaminRodenberg BenjaminRodenberg self-assigned this Aug 5, 2022
@BenjaminRodenberg BenjaminRodenberg added this to the Version 3.0.0 milestone Aug 5, 2022
@BenjaminRodenberg BenjaminRodenberg added maintainability Working on this will make our lives easier in the long run as preCICE gets easier to maintain. breaking change Breaks backwards compatibility and users need to act labels Aug 5, 2022
BenjaminRodenberg and others added 7 commits August 5, 2022 12:19
* Remove mapReadDataTo and mapWriteDataFrom.
* Remove tests using removed API.
* Merge initialize and initializeData in SolverInterfaceImpl.
* Merge initialize and initializeData in CouplingScheme.
* Update tests correspondingly
* Allow to check actions before initialize, especially checking whether initial data has to be written
* Check for sending and receiving of initial data during coupling scheme configuration
* Code simplification w.r.t waveform.
* Use dt=0.0 in actions in initialize.

Co-authored-by: Benjamin Uekermann <[email protected]>
Co-authored-by: Frédéric Simonis <[email protected]>
…recice#1352)

* Get tests and configs for serial implicit waveform interpolation from precice#1029.
* Differentiate between received initial data and data (from advance).
* Split data communication for SerialCouplingScheme and store initial data in waveform.
* Move common functionality of serial and parallel coupling scheme into BiCouplingScheme.

Co-authored-by: Benjamin Uekermann <[email protected]>
* Add test Integration/Serial/InitializeData/ImplicitBoth where both participants initialize.
* Allow initialize=true for both participants in serial-implicit coupling scheme.
* Raise warning, if first participant in serial coupling scheme initializes data with waveform order zero.
* Remove check for write data, because participant does not know about waveform order.

Co-authored-by: Benjamin Uekermann <[email protected]>
Copy link
Copy Markdown
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Co-authored-by: Benjamin Uekermann <[email protected]>
@BenjaminRodenberg BenjaminRodenberg merged commit cd0fb02 into precice:develop-v3.0.0 Aug 8, 2022
BenjaminRodenberg added a commit that referenced this pull request Aug 11, 2022
BenjaminRodenberg added a commit that referenced this pull request Aug 22, 2022
BenjaminRodenberg added a commit that referenced this pull request Aug 22, 2022
BenjaminRodenberg added a commit that referenced this pull request Sep 15, 2022
BenjaminRodenberg added a commit that referenced this pull request Nov 2, 2022
BenjaminRodenberg added a commit that referenced this pull request Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Breaks backwards compatibility and users need to act maintainability Working on this will make our lives easier in the long run as preCICE gets easier to maintain.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants