Conversation
BenjaminRodenberg
added
maintainability
BenjaminRodenberg
force-pushed
the
develop-v3.0.0
branch
from
8d3aff4 to
8338d6a
Compare
7 tasks
BenjaminRodenberg
force-pushed
the
develop-v3.0.0
branch
from
08d36dc to
105c3ef
Compare
BenjaminRodenberg
force-pushed
the
develop-v3.0.0
branch
3 times, most recently
from
72a6b20 to
e314f68
Compare
BenjaminRodenberg
force-pushed
the
develop-v3.0.0
branch
2 times, most recently
from
cd600f5 to
f3ef21d
Compare
BenjaminRodenberg
force-pushed
the
develop-v3.0.0
branch
from
f3ef21d to
85c325a
Compare
This was referenced Oct 31, 2022
BenjaminRodenberg
force-pushed
the
develop-v3.0.0
branch
from
49e7c2a to
565d8ff
Compare
* Remove mapReadDataTo and mapWriteDataFrom. * Remove tests using removed API.
* Merge initialize and initializeData in SolverInterfaceImpl. * Merge initialize and initializeData in CouplingScheme. * Update tests correspondingly * Allow to check actions before initialize, especially checking whether initial data has to be written * Check for sending and receiving of initial data during coupling scheme configuration * Code simplification w.r.t waveform. * Use dt=0.0 in actions in initialize. Co-authored-by: Benjamin Uekermann <[email protected]> Co-authored-by: Frédéric Simonis <[email protected]>
…1352) * Get tests and configs for serial implicit waveform interpolation from #1029. * Differentiate between received initial data and data (from advance). * Split data communication for SerialCouplingScheme and store initial data in waveform. * Move common functionality of serial and parallel coupling scheme into BiCouplingScheme. Co-authored-by: Benjamin Uekermann <[email protected]>
* Add test Integration/Serial/InitializeData/ImplicitBoth where both participants initialize. * Allow initialize=true for both participants in serial-implicit coupling scheme. * Raise warning, if first participant in serial coupling scheme initializes data with waveform order zero. * Remove check for write data, because participant does not know about waveform order. Co-authored-by: Benjamin Uekermann <[email protected]>
Co-authored-by: Benjamin Uekermann <[email protected]>
* Make read mapping conditional to avoid unnecessary mappings. * Update corresponding tests. Co-authored-by: Benjamin Uekermann <[email protected]>
…-order interpolation through BSplines (#1422) * Allow to store multiple samples within one window. * Allow higher-order interpolation through B-Splines, if sufficiently many samples are available. * Simplifies Waveform by removing data from past windows and support for second-order interpolation by using data from old window. * Reset all samples when window is repeated - except the sample at the beginning of the window. * Update intergration tests for zeroth order interpolation for more consistent behavior with first order interpolation. * Introduce time::Storage Co-authored-by: Benjamin Uekermann <[email protected]>
…nSize for better encapsulation. (#1442)
* Add test and allow waveforms in multi-coupling.
* Increase timeouts for precice.cplscheme and precice.integration.Serial, because they will take longer with new tests introduced in #1414 Co-authored-by: Frédéric Simonis <[email protected]>
BenjaminRodenberg
force-pushed
the
develop-v3.0.0
branch
from
721976f to
c5c7b50
Compare
Member
|
Please don't forget to add all changes to the porting guide. |
Contributor
Author
I added a PR precice/precice.github.io#223 and some porting instructions for |
This was referenced Nov 17, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes of this PR
Breaks develop. Only merge this PR as soon as the last release before the breaking release v3.0.0 is published.
Closes #834
Closes #859
Closes #934
Closes #1174
Closes #1196
Closes #1223
Closes #1358
Closes #1367
Closes #1421
Motivation and additional information
At some point in time we need to break develop. Because some breaking developments already exist now, but cannot be merged now I created this breaking branch.
Note: We might need to rebase this branch depending on the number of changes on
developthat will be introduced before being able to merge it.Todo
Update lists of Issues being closed.
Author's checklist
I added a changelog file withnot necessary, because the changelog files already come from the individual feature PRs.make changelogif there are user-observable changes since the last release.make formatto ensure everything is formatted correctly.Reviewers' checklist