Skip to content

Merge initializeData() into initialize()#1350

Merged
BenjaminRodenberg merged 113 commits intodevelop-v3.0.0from
1196-merge-initialize-initializeData
Jul 11, 2022
Merged

Merge initializeData() into initialize()#1350
BenjaminRodenberg merged 113 commits intodevelop-v3.0.0from
1196-merge-initialize-initializeData

Conversation

@BenjaminRodenberg
Copy link
Copy Markdown
Contributor

@BenjaminRodenberg BenjaminRodenberg commented Jul 1, 2022

Main changes of this PR

Closes #1196 by performing data initialization directly in initialize. Removes initializeData().

Motivation and additional information

See #1196.
Also helps to close related issue #1349.

Todo

Author's checklist

  • I added a changelog file with make changelog if there are user-observable changes since the last release.
  • I ran make format to ensure everything is formatted correctly.
  • I sticked to C++14 features.
  • I sticked to CMake version 3.16.3.
  • I squashed / am about to squash all commits that should be seen as one.

Reviewers' checklist

  • Does the changelog entry make sense? Is it formatted correctly?
  • Do you understand the code changes?

fsimonis and others added 30 commits March 10, 2022 18:19
…ce/precice into 1149-restructure-integration-tests
…ce/precice into 1149-restructure-integration-tests
…ce/precice into 1149-restructure-integration-tests
…ce/precice into 1149-restructure-integration-tests
@BenjaminRodenberg
Copy link
Copy Markdown
Contributor Author

#1362 has simplified this PR a lot. @uekerman do you want to take another look? From my perspective this PR is ready to merge.

@BenjaminRodenberg
Copy link
Copy Markdown
Contributor Author

@uekerman: Should we generally remove the restriction that first cannot initializeData already here? See precice/precice.github.io#174 (comment). I think this might simplify code and the API furtherly.

Copy link
Copy Markdown
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@uekerman
Copy link
Copy Markdown
Member

@uekerman: Should we generally remove the restriction that first cannot initializeData already here? See precice/precice.github.io#174 (comment). I think this might simplify code and the API furtherly.

No, let's do this separately. Can't overview it yet.

@BenjaminRodenberg BenjaminRodenberg merged commit 8d3aff4 into develop-v3.0.0 Jul 11, 2022
BenjaminRodenberg added a commit that referenced this pull request Jul 12, 2022
* Merge initialize and initializeData in SolverInterfaceImpl.
* Merge initialize and initializeData in CouplingScheme.
* Update tests correspondingly
* Allow to check actions before initialize, especially checking whether initial data has to be written
* Check for sending and receiving of initial data during coupling scheme configuration
* Code simplification w.r.t waveform.
* Use dt=0.0 in actions in initialize.

Co-authored-by: Benjamin Uekermann <[email protected]>
Co-authored-by: Frédéric Simonis <[email protected]>
BenjaminRodenberg added a commit that referenced this pull request Jul 29, 2022
* Merge initialize and initializeData in SolverInterfaceImpl.
* Merge initialize and initializeData in CouplingScheme.
* Update tests correspondingly
* Allow to check actions before initialize, especially checking whether initial data has to be written
* Check for sending and receiving of initial data during coupling scheme configuration
* Code simplification w.r.t waveform.
* Use dt=0.0 in actions in initialize.

Co-authored-by: Benjamin Uekermann <[email protected]>
Co-authored-by: Frédéric Simonis <[email protected]>
BenjaminRodenberg added a commit that referenced this pull request Aug 5, 2022
* Merge initialize and initializeData in SolverInterfaceImpl.
* Merge initialize and initializeData in CouplingScheme.
* Update tests correspondingly
* Allow to check actions before initialize, especially checking whether initial data has to be written
* Check for sending and receiving of initial data during coupling scheme configuration
* Code simplification w.r.t waveform.
* Use dt=0.0 in actions in initialize.

Co-authored-by: Benjamin Uekermann <[email protected]>
Co-authored-by: Frédéric Simonis <[email protected]>
BenjaminRodenberg added a commit that referenced this pull request Aug 5, 2022
* Merge initialize and initializeData in SolverInterfaceImpl.
* Merge initialize and initializeData in CouplingScheme.
* Update tests correspondingly
* Allow to check actions before initialize, especially checking whether initial data has to be written
* Check for sending and receiving of initial data during coupling scheme configuration
* Code simplification w.r.t waveform.
* Use dt=0.0 in actions in initialize.

Co-authored-by: Benjamin Uekermann <[email protected]>
Co-authored-by: Frédéric Simonis <[email protected]>
BenjaminRodenberg added a commit that referenced this pull request Aug 11, 2022
* Merge initialize and initializeData in SolverInterfaceImpl.
* Merge initialize and initializeData in CouplingScheme.
* Update tests correspondingly
* Allow to check actions before initialize, especially checking whether initial data has to be written
* Check for sending and receiving of initial data during coupling scheme configuration
* Code simplification w.r.t waveform.
* Use dt=0.0 in actions in initialize.

Co-authored-by: Benjamin Uekermann <[email protected]>
Co-authored-by: Frédéric Simonis <[email protected]>
BenjaminRodenberg added a commit that referenced this pull request Aug 22, 2022
* Merge initialize and initializeData in SolverInterfaceImpl.
* Merge initialize and initializeData in CouplingScheme.
* Update tests correspondingly
* Allow to check actions before initialize, especially checking whether initial data has to be written
* Check for sending and receiving of initial data during coupling scheme configuration
* Code simplification w.r.t waveform.
* Use dt=0.0 in actions in initialize.

Co-authored-by: Benjamin Uekermann <[email protected]>
Co-authored-by: Frédéric Simonis <[email protected]>
@fsimonis fsimonis mentioned this pull request Sep 6, 2022
9 tasks
BenjaminRodenberg added a commit that referenced this pull request Sep 15, 2022
* Merge initialize and initializeData in SolverInterfaceImpl.
* Merge initialize and initializeData in CouplingScheme.
* Update tests correspondingly
* Allow to check actions before initialize, especially checking whether initial data has to be written
* Check for sending and receiving of initial data during coupling scheme configuration
* Code simplification w.r.t waveform.
* Use dt=0.0 in actions in initialize.

Co-authored-by: Benjamin Uekermann <[email protected]>
Co-authored-by: Frédéric Simonis <[email protected]>
BenjaminRodenberg added a commit that referenced this pull request Nov 2, 2022
* Merge initialize and initializeData in SolverInterfaceImpl.
* Merge initialize and initializeData in CouplingScheme.
* Update tests correspondingly
* Allow to check actions before initialize, especially checking whether initial data has to be written
* Check for sending and receiving of initial data during coupling scheme configuration
* Code simplification w.r.t waveform.
* Use dt=0.0 in actions in initialize.

Co-authored-by: Benjamin Uekermann <[email protected]>
Co-authored-by: Frédéric Simonis <[email protected]>
BenjaminRodenberg added a commit that referenced this pull request Nov 4, 2022
* Merge initialize and initializeData in SolverInterfaceImpl.
* Merge initialize and initializeData in CouplingScheme.
* Update tests correspondingly
* Allow to check actions before initialize, especially checking whether initial data has to be written
* Check for sending and receiving of initial data during coupling scheme configuration
* Code simplification w.r.t waveform.
* Use dt=0.0 in actions in initialize.

Co-authored-by: Benjamin Uekermann <[email protected]>
Co-authored-by: Frédéric Simonis <[email protected]>
erikscheurer added a commit to precice/PreCICE.jl that referenced this pull request Jan 2, 2023
@BenjaminRodenberg BenjaminRodenberg deleted the 1196-merge-initialize-initializeData branch February 23, 2023 10:17
IshaanDesai pushed a commit to precice/PreCICE.jl that referenced this pull request Mar 16, 2023
* Remove mapWriteDataFrom (precice/precice#1222) and Vertex-only API (precice/precice#1322)

* Remove `initializeData` (precice/precice#1350)

* Remove `isReadDataAvailable` and `isWriteDataRequired` (precice/precice#1362)

* Rename `isGradientDataRequired` (precice/precice@632b4fb)

* Remove `isActionRequired` and replace with explicit calls

* Adjust Solverdummies and tests

* Format changes

* [WIP]  Use names instead of IDs  related to precice/precice#1588

* Delete functions not part of the precice API

* Implement API changes into tests

* Format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Breaks backwards compatibility and users need to act usability This issue will make preCICE easier for non-expert users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make calling initializeData mandatory?

4 participants