Merge initializeData() into initialize()#1350
Merged
BenjaminRodenberg merged 113 commits intodevelop-v3.0.0from Jul 11, 2022
Merged
Merge initializeData() into initialize()#1350BenjaminRodenberg merged 113 commits intodevelop-v3.0.0from
BenjaminRodenberg merged 113 commits intodevelop-v3.0.0from
Conversation
…ce/precice into 1149-restructure-integration-tests
…ce/precice into 1149-restructure-integration-tests
…ce/precice into 1149-restructure-integration-tests
…ce/precice into 1149-restructure-integration-tests
… into 1196-merge-initialize-initializeData
Contributor
Author
1 task
Contributor
Author
|
@uekerman: Should we generally remove the restriction that first cannot initializeData already here? See precice/precice.github.io#174 (comment). I think this might simplify code and the API furtherly. |
Member
No, let's do this separately. Can't overview it yet. |
BenjaminRodenberg
added a commit
that referenced
this pull request
Jul 12, 2022
* Merge initialize and initializeData in SolverInterfaceImpl. * Merge initialize and initializeData in CouplingScheme. * Update tests correspondingly * Allow to check actions before initialize, especially checking whether initial data has to be written * Check for sending and receiving of initial data during coupling scheme configuration * Code simplification w.r.t waveform. * Use dt=0.0 in actions in initialize. Co-authored-by: Benjamin Uekermann <[email protected]> Co-authored-by: Frédéric Simonis <[email protected]>
7 tasks
BenjaminRodenberg
added a commit
that referenced
this pull request
Jul 29, 2022
* Merge initialize and initializeData in SolverInterfaceImpl. * Merge initialize and initializeData in CouplingScheme. * Update tests correspondingly * Allow to check actions before initialize, especially checking whether initial data has to be written * Check for sending and receiving of initial data during coupling scheme configuration * Code simplification w.r.t waveform. * Use dt=0.0 in actions in initialize. Co-authored-by: Benjamin Uekermann <[email protected]> Co-authored-by: Frédéric Simonis <[email protected]>
BenjaminRodenberg
added a commit
that referenced
this pull request
Aug 5, 2022
* Merge initialize and initializeData in SolverInterfaceImpl. * Merge initialize and initializeData in CouplingScheme. * Update tests correspondingly * Allow to check actions before initialize, especially checking whether initial data has to be written * Check for sending and receiving of initial data during coupling scheme configuration * Code simplification w.r.t waveform. * Use dt=0.0 in actions in initialize. Co-authored-by: Benjamin Uekermann <[email protected]> Co-authored-by: Frédéric Simonis <[email protected]>
BenjaminRodenberg
added a commit
that referenced
this pull request
Aug 5, 2022
* Merge initialize and initializeData in SolverInterfaceImpl. * Merge initialize and initializeData in CouplingScheme. * Update tests correspondingly * Allow to check actions before initialize, especially checking whether initial data has to be written * Check for sending and receiving of initial data during coupling scheme configuration * Code simplification w.r.t waveform. * Use dt=0.0 in actions in initialize. Co-authored-by: Benjamin Uekermann <[email protected]> Co-authored-by: Frédéric Simonis <[email protected]>
BenjaminRodenberg
added a commit
that referenced
this pull request
Aug 11, 2022
* Merge initialize and initializeData in SolverInterfaceImpl. * Merge initialize and initializeData in CouplingScheme. * Update tests correspondingly * Allow to check actions before initialize, especially checking whether initial data has to be written * Check for sending and receiving of initial data during coupling scheme configuration * Code simplification w.r.t waveform. * Use dt=0.0 in actions in initialize. Co-authored-by: Benjamin Uekermann <[email protected]> Co-authored-by: Frédéric Simonis <[email protected]>
BenjaminRodenberg
added a commit
that referenced
this pull request
Aug 22, 2022
* Merge initialize and initializeData in SolverInterfaceImpl. * Merge initialize and initializeData in CouplingScheme. * Update tests correspondingly * Allow to check actions before initialize, especially checking whether initial data has to be written * Check for sending and receiving of initial data during coupling scheme configuration * Code simplification w.r.t waveform. * Use dt=0.0 in actions in initialize. Co-authored-by: Benjamin Uekermann <[email protected]> Co-authored-by: Frédéric Simonis <[email protected]>
BenjaminRodenberg
added a commit
that referenced
this pull request
Sep 15, 2022
* Merge initialize and initializeData in SolverInterfaceImpl. * Merge initialize and initializeData in CouplingScheme. * Update tests correspondingly * Allow to check actions before initialize, especially checking whether initial data has to be written * Check for sending and receiving of initial data during coupling scheme configuration * Code simplification w.r.t waveform. * Use dt=0.0 in actions in initialize. Co-authored-by: Benjamin Uekermann <[email protected]> Co-authored-by: Frédéric Simonis <[email protected]>
BenjaminRodenberg
added a commit
that referenced
this pull request
Nov 2, 2022
* Merge initialize and initializeData in SolverInterfaceImpl. * Merge initialize and initializeData in CouplingScheme. * Update tests correspondingly * Allow to check actions before initialize, especially checking whether initial data has to be written * Check for sending and receiving of initial data during coupling scheme configuration * Code simplification w.r.t waveform. * Use dt=0.0 in actions in initialize. Co-authored-by: Benjamin Uekermann <[email protected]> Co-authored-by: Frédéric Simonis <[email protected]>
BenjaminRodenberg
added a commit
that referenced
this pull request
Nov 4, 2022
* Merge initialize and initializeData in SolverInterfaceImpl. * Merge initialize and initializeData in CouplingScheme. * Update tests correspondingly * Allow to check actions before initialize, especially checking whether initial data has to be written * Check for sending and receiving of initial data during coupling scheme configuration * Code simplification w.r.t waveform. * Use dt=0.0 in actions in initialize. Co-authored-by: Benjamin Uekermann <[email protected]> Co-authored-by: Frédéric Simonis <[email protected]>
1 task
erikscheurer
added a commit
to precice/PreCICE.jl
that referenced
this pull request
Jan 2, 2023
IshaanDesai
pushed a commit
to precice/PreCICE.jl
that referenced
this pull request
Mar 16, 2023
* Remove mapWriteDataFrom (precice/precice#1222) and Vertex-only API (precice/precice#1322) * Remove `initializeData` (precice/precice#1350) * Remove `isReadDataAvailable` and `isWriteDataRequired` (precice/precice#1362) * Rename `isGradientDataRequired` (precice/precice@632b4fb) * Remove `isActionRequired` and replace with explicit calls * Adjust Solverdummies and tests * Format changes * [WIP] Use names instead of IDs related to precice/precice#1588 * Delete functions not part of the precice API * Implement API changes into tests * Format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes of this PR
Closes #1196 by performing data initialization directly in
initialize. RemovesinitializeData().Motivation and additional information
See #1196.
Also helps to close related issue #1349.
Todo
Author's checklist
make changelogif there are user-observable changes since the last release.make formatto ensure everything is formatted correctly.Reviewers' checklist