Skip to content

Add failing test to reproduce first-participant + initData problem#1349

Merged
uekerman merged 1 commit intoprecice:develop-v3.0.0from
uekerman:add-test-first-participant-init-data
Jul 21, 2022
Merged

Add failing test to reproduce first-participant + initData problem#1349
uekerman merged 1 commit intoprecice:develop-v3.0.0from
uekerman:add-test-first-participant-init-data

Conversation

@uekerman
Copy link
Copy Markdown
Member

@uekerman uekerman commented Jul 1, 2022

Main changes of this PR

Adds the remaining failing test from #1307
Needs breaking changes to be fixed, see also #1347

Author's checklist

  • I added a changelog file with make changelog if there are user-observable changes since the last release.
  • I ran make format to ensure everything is formatted correctly.
  • I sticked to C++14 features.
  • I sticked to CMake version 3.16.3.
  • I squashed / am about to squash all commits that should be seen as one.

Reviewers' checklist

  • Does the changelog entry make sense? Is it formatted correctly?
  • Do you understand the code changes?

@uekerman uekerman added the breaking change Breaks backwards compatibility and users need to act label Jul 1, 2022
@uekerman uekerman added this to the Version 3.0.0 milestone Jul 1, 2022
@uekerman uekerman self-assigned this Jul 1, 2022
@uekerman uekerman mentioned this pull request Jul 1, 2022
Closed
@BenjaminRodenberg BenjaminRodenberg mentioned this pull request Jul 1, 2022
Closed
7 tasks
@BenjaminRodenberg
Copy link
Copy Markdown
Contributor

BenjaminRodenberg commented Jul 3, 2022

I just tried out merging #1350 @ e8f738d into this PR and the issue is resolved. I will not push the merge, because the changes are trivial and it just makes the history more complicated.

@BenjaminRodenberg BenjaminRodenberg mentioned this pull request Jul 3, 2022
Merged
9 tasks
@BenjaminRodenberg
Copy link
Copy Markdown
Contributor

BenjaminRodenberg commented Jul 20, 2022

@uekerman what should we do with this PR? I think we can merge it into #1366. We can still keep the issue open, but it will be resolved in preCICE v3.0.0.

@uekerman uekerman changed the base branch from develop to develop-v3.0.0 July 21, 2022 08:12
@uekerman uekerman force-pushed the add-test-first-participant-init-data branch from 07ee291 to c67be0e Compare July 21, 2022 08:21
@uekerman uekerman marked this pull request as ready for review July 21, 2022 08:21
@uekerman
Copy link
Copy Markdown
Member Author

uekerman commented Jul 21, 2022

What should we do with this PR? I think we can merge it into #1366. We can still keep the issue open, but it will be resolved in preCICE v3.0.0.

Yes, good point. I rebased on develop-v3.0.0 and changed the target branch.

@uekerman uekerman merged commit c18e658 into precice:develop-v3.0.0 Jul 21, 2022
uekerman added a commit that referenced this pull request Jul 21, 2022
@uekerman
Add integration test to reproduce first-participant + initData problem (
08d36dc 
#1349)
BenjaminRodenberg pushed a commit that referenced this pull request Jul 29, 2022
@uekerman @BenjaminRodenberg
Add integration test to reproduce first-participant + initData problem (
105c3ef 
#1349)
BenjaminRodenberg pushed a commit that referenced this pull request Aug 5, 2022
@uekerman @BenjaminRodenberg
Add integration test to reproduce first-participant + initData problem (
436fcd5 
#1349)
BenjaminRodenberg pushed a commit that referenced this pull request Aug 5, 2022
@uekerman @BenjaminRodenberg
Add integration test to reproduce first-participant + initData problem (
6a5f5a3 
#1349)
BenjaminRodenberg pushed a commit that referenced this pull request Aug 11, 2022
@uekerman @BenjaminRodenberg
Add integration test to reproduce first-participant + initData problem (
5e67a8c 
#1349)
BenjaminRodenberg pushed a commit that referenced this pull request Aug 22, 2022
@uekerman @BenjaminRodenberg
Add integration test to reproduce first-participant + initData problem (
567b265 
#1349)
BenjaminRodenberg pushed a commit that referenced this pull request Sep 15, 2022
@uekerman @BenjaminRodenberg
Add integration test to reproduce first-participant + initData problem (
3bab6df 
#1349)
BenjaminRodenberg pushed a commit that referenced this pull request Nov 2, 2022
@uekerman @BenjaminRodenberg
Add integration test to reproduce first-participant + initData problem (
f174c07 
#1349)
BenjaminRodenberg pushed a commit that referenced this pull request Nov 4, 2022
@uekerman @BenjaminRodenberg
Add integration test to reproduce first-participant + initData problem (
08cd6b9 
#1349)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@uekerman uekerman

Labels

breaking change Breaks backwards compatibility and users need to act

Projects

None yet

Milestone

Version 3.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@uekerman @BenjaminRodenberg