Merged
Conversation
fsimonis
added
the
breaking change
fsimonis
added
the
usability
davidscn
reviewed
Jun 14, 2022
fsimonis
force-pushed
the
vertex-only-api
branch
2 times, most recently
from
cd84888 to
1635075
Compare
7 tasks
Co-authored-by: Benjamin Uekermann <[email protected]>
fsimonis
force-pushed
the
vertex-only-api
branch
from
1635075 to
4ed2b56
Compare
Member
Author
7 tasks
uekerman
requested changes
Nov 25, 2022
Member
uekerman
left a comment
uekerman
left a comment
There was a problem hiding this comment.
Looks pretty clean already. I tried to have a thorough look, but I did not try it out.
A bit concerning is still the limited test coverage for the bindings -> We might find issues while porting adapters.
Co-authored-by: Benjamin Uekermann <[email protected]>
Co-authored-by: Benjamin Uekermann <[email protected]>
uekerman
approved these changes
Nov 28, 2022
Member
uekerman
left a comment
uekerman
left a comment
There was a problem hiding this comment.
Good to go from my side, but I did not try it out.
erikscheurer
added a commit
to precice/PreCICE.jl
that referenced
this pull request
Jan 2, 2023
This was referenced Feb 6, 2023
IshaanDesai
pushed a commit
to precice/PreCICE.jl
that referenced
this pull request
Mar 16, 2023
* Remove mapWriteDataFrom (precice/precice#1222) and Vertex-only API (precice/precice#1322) * Remove `initializeData` (precice/precice#1350) * Remove `isReadDataAvailable` and `isWriteDataRequired` (precice/precice#1362) * Rename `isGradientDataRequired` (precice/precice@632b4fb) * Remove `isActionRequired` and replace with explicit calls * Adjust Solverdummies and tests * Format changes * [WIP] Use names instead of IDs related to precice/precice#1588 * Delete functions not part of the precice API * Implement API changes into tests * Format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes of this PR
This PR removes all edge ids from the API and converts
setMeshXWithEdgesfunctions tosetMeshX.The API now guarantees the creation of implicit connectivity information.
This PR is based on #1312.
Motivation and additional information
See #1321
This only ports the integration tests to the edge-less API.
A further step would be to remove
Mesh::createTriangle(Edge&, Edge&, Edge&), which impacts many tests.Author's checklist
make changelogif there are user-observable changes since the last release.make formatto ensure everything is formatted correctly.Reviewers' checklist