Skip to content

Refactor cplscheme tests#1215

Merged
BenjaminRodenberg merged 2 commits intoprecice:developfrom
BenjaminRodenberg:refactor-cplscheme-tests
Mar 25, 2022
Merged

Refactor cplscheme tests#1215
BenjaminRodenberg merged 2 commits intoprecice:developfrom
BenjaminRodenberg:refactor-cplscheme-tests

Conversation

@BenjaminRodenberg
Copy link
Copy Markdown
Contributor

@BenjaminRodenberg BenjaminRodenberg commented Mar 22, 2022

Main changes of this PR

  • Make configuration files valid by adding participants.
  • Also provide participant configuration.
  • Refactor tests w.r.t readability.

Motivation and additional information

Reduces complexity of #1187.

Author's checklist

  • I added a changelog file with make changelog if there are user-observable changes since the last release.
  • I ran make format to ensure everything is formatted correctly.
  • I sticked to C++14 features.
  • I sticked to CMake version 3.10.
  • I squashed / am about to squash all commits that should be seen as one.

Reviewers' checklist

  • Does the changelog entry make sense? Is it formatted correctly?
  • Do you understand the code changes?

@BenjaminRodenberg
Refactor cplscheme tests
7300b9d 
* Make configuration files valid by adding participants.
* Also provide participant configuration.
* Refactor tests w.r.t readability.
@BenjaminRodenberg BenjaminRodenberg added the maintainability Working on this will make our lives easier in the long run as preCICE gets easier to maintain. label Mar 22, 2022
@BenjaminRodenberg BenjaminRodenberg self-assigned this Mar 22, 2022
@BenjaminRodenberg BenjaminRodenberg mentioned this pull request Mar 22, 2022
Merged
12 tasks
@BenjaminRodenberg
Copy link
Copy Markdown
Contributor Author

BenjaminRodenberg commented Mar 22, 2022

@uekerman I can also split this PR into two:

  1. Take care of the dimensions changes.
  2. Take care of the participant changes in the config files.

uekerman
uekerman approved these changes Mar 25, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
I did not check whether the new config files are correct.
Maybe quickly visualizing all of them could raise confidence?

@BenjaminRodenberg BenjaminRodenberg merged commit 851e1aa into precice:develop Mar 25, 2022
@BenjaminRodenberg BenjaminRodenberg deleted the refactor-cplscheme-tests branch March 25, 2022 12:40
@fsimonis fsimonis added this to the Version 2.4.0 milestone May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uekerman uekerman uekerman approved these changes

Assignees

@BenjaminRodenberg BenjaminRodenberg

Labels

maintainability Working on this will make our lives easier in the long run as preCICE gets easier to maintain.

Projects

None yet

Milestone

Version 2.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@BenjaminRodenberg @uekerman @fsimonis