Skip to content

Restructure integration tests#1205

Merged
davidscn merged 69 commits intodevelopfrom
1149-restructure-integration-tests
Mar 28, 2022
Merged

Restructure integration tests#1205
davidscn merged 69 commits intodevelopfrom
1149-restructure-integration-tests

Conversation

@davidscn
Copy link
Copy Markdown
Member

@davidscn davidscn commented Mar 16, 2022 •
edited
Loading

Main changes of this PR

Restructure the serial and parallel integration tests as discussed in #1149.

Motivation and additional information

Depends on #1202

Author's checklist

  • I added a changelog file with make changelog if there are user-observable changes since the last release.
  • I ran make format to ensure everything is formatted correctly.
  • I sticked to C++14 features.
  • I sticked to CMake version 3.10.
  • I squashed / am about to squash all commits that should be seen as one.
  • Open issue on unmaintained tests (e.g. the parallel multi-coupling tests)

Reviewers' checklist

  • Does the changelog entry make sense? Is it formatted correctly?
  • Do you understand the code changes?

fsimonis and others added 30 commits March 10, 2022 18:19
@fsimonis
Auto generate test suites
30924ce
@fsimonis
Update files
a18822f
@fsimonis
Add reminder to run updateSourceFiles
a044834
@davidscn
Restructure Lifecycle/ImplicitFinalize
9a61dfb
@BenjaminRodenberg
Move TestConfigurationPeano and TestConfigurationComsol.
db4368c
@davidscn
:Restructure Parallel/lifecycle/Full
4fca910
@davidscn
Merge branch '1149-restructure-integration-tests' of github.com:preci…
6c257ac 
…ce/precice into 1149-restructure-integration-tests
@BenjaminRodenberg
Further clean up and adding missing documentation.
da59a4a
@davidscn
Restructure Parallel/lifecycle/ConstructOnly
b43ec7b
@davidscn
Restructure Parallel/lifecycle/ConstructAndExplicitFinalize
1c948f6
@BenjaminRodenberg
Move TestExplicitWithDataScaling.
be6145e
@BenjaminRodenberg
Merge branch '1149-restructure-integration-tests' of github.com:preci…
43acc04 
…ce/precice into 1149-restructure-integration-tests
@davidscn
Restructure parallel/TestFinalize
fff4cc3
@BenjaminRodenberg
Move Serial/MeshRequirements.
1413fe6
@BenjaminRodenberg
Merge branch '1149-restructure-integration-tests' of github.com:preci…
12f4b02 
…ce/precice into 1149-restructure-integration-tests
@BenjaminRodenberg
Fix format.
0e0efad
@davidscn
Restructure Parallel/GlobalRBF
82b362f
@davidscn
Restructure LocalRBFPartitioning
d81cc9b
@davidscn
Restructure Parallel/CouplingOnLine
aafa557
@davidscn
Restructure parallel/TestBoundingBoxInit
f534614
@davidscn
Restructure Parallel/TestBoundingBoxInitTwoWay
2d3ee49
@davidscn
Restructure Parallel/NearestProjectionRePartitioning
bd4a7bf
@davidscn
Restructure Parallel/MasterSockets and Parallel/UserDefinedMPIComm
7049dff
@davidscn
Restructure Parallel/UserDefinedMPICommunicatorPetRBF
58789da
@davidscn
Restructure Parallel/ExportTimeSeries
9c1a3a9
@BenjaminRodenberg
Move multi coupling into its own suite.
6f6ed0a
@BenjaminRodenberg
Merge branch '1149-restructure-integration-tests' of github.com:preci…
52c5ab2 
…ce/precice into 1149-restructure-integration-tests
@BenjaminRodenberg
Move MultiCouplingThreeSolvers.
4bbe656
@BenjaminRodenberg
Move lifecycle tests.
7ce0fe7
@BenjaminRodenberg
Fix includes.
3acf2f0
@davidscn davidscn marked this pull request as ready for review March 24, 2022 22:14
@davidscn davidscn added the maintainability Working on this will make our lives easier in the long run as preCICE gets easier to maintain. label Mar 24, 2022
@davidscn davidscn linked an issue Mar 24, 2022 that may be closed by this pull request
Move all integration tests to new structure #1149
Closed
BenjaminRodenberg
BenjaminRodenberg suggested changes Mar 25, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already looks very good.

Open points I see here:

  • In ParallelTests.cpp and SerialTests.cpp there is still dead code. @fsimonis can you comment here? We should either revive the tests, open an issue or delete them (we can still revive them later from the history). 503ecca and bd0e158 are the relevant commits here from my perspective.
  • Are the remaining configuration files in precice/tests actually needed? If not, we should also delete them. explicit-direct-access-two-level.xml seems to be unused; cplmode-1.xml is also unused; explicit-mpi-single-non-inc.xml is only used by a commented out test. config-checker.xml is fine, because it is used by ToolingTests.cpp.

@davidscn
Copy link
Copy Markdown
Member Author

davidscn commented Mar 25, 2022

The ParallelTests are actually already a TODO in the checklist on top. The dead SerialTests are somewhat of a crime by @fsimonis and I don't know what to do with them. I will clean-up the xml files.

@fsimonis
Copy link
Copy Markdown
Member

fsimonis commented Mar 25, 2022

@davidscn don't shoot the one that formatted the entire codebase. 😁

@fsimonis
Copy link
Copy Markdown
Member

fsimonis commented Mar 25, 2022

@davidscn you can remove the resetMesh serial tests, I will implement a complete test suite instead. This closes #1100

@uekerman @oguzziya Do you remember why the parallel tests regarding multi-coupling-schemes were disable in 8354dab?

@davidscn
Copy link
Copy Markdown
Member Author

davidscn commented Mar 26, 2022

@fsimonis No shots fired ;)

Do you remember why the parallel tests regarding multi-coupling-schemes were disable in 8354dab?

Answer from @oguzziya was

they are to be added once precice/precice#1025 also works for a parallel "controller"/ the cases were supposed to be failing right now

I will open up an issue on that.

@davidscn davidscn mentioned this pull request Mar 26, 2022
Open
@davidscn davidscn added this to the Version 2.4.0 milestone Mar 26, 2022
BenjaminRodenberg
BenjaminRodenberg approved these changes Mar 26, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Minor comments below, but from my perspective this is good to go.

Comment thread docs/changelog/1205.md Outdated
Comment thread src/tests.cmake
@davidscn @BenjaminRodenberg
Update docs/changelog/1205.md
bca0607 
Co-authored-by: Benjamin Rodenberg <[email protected]>
@BenjaminRodenberg BenjaminRodenberg mentioned this pull request Mar 26, 2022
Merged
8 tasks
@davidscn davidscn merged commit b3cc263 into develop Mar 28, 2022
@davidscn davidscn deleted the 1149-restructure-integration-tests branch March 28, 2022 19:09
@fsimonis fsimonis mentioned this pull request Mar 29, 2022
Merged
5 tasks
This was referenced Feb 9, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fsimonis fsimonis Awaiting requested review from fsimonis

1 more reviewer

@BenjaminRodenberg BenjaminRodenberg BenjaminRodenberg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@BenjaminRodenberg BenjaminRodenberg

@davidscn davidscn

Labels

maintainability Working on this will make our lives easier in the long run as preCICE gets easier to maintain.

Projects

None yet

Milestone

Version 2.4.0

Development

Successfully merging this pull request may close these issues.

Move all integration tests to new structure

3 participants

@davidscn @fsimonis @BenjaminRodenberg