Add Access to Mesh Requirements via API#1080
Merged
fsimonis merged 9 commits intoprecice:developfrom Sep 15, 2021
Merged
Conversation
fsimonis
force-pushed
the
add-access-meshrequirement
branch
from
e3daff4 to
caea77e
Compare
fsimonis
force-pushed
the
add-access-meshrequirement
branch
from
caea77e to
2b84713
Compare
Member
Author
|
Based on the discussion in #467, I reduced this PR from 2 API functions down to 1. |
fsimonis
added
the
enhancement
uekerman
requested changes
Sep 14, 2021
Member
uekerman
left a comment
uekerman
left a comment
There was a problem hiding this comment.
Implementation and tests look good 👍
Only a few doubt about the C and Fortran bindings. It's really problematic that we don't have tests here (preSERVE 😢 ) ... what you could always do is to quickly modify a solverdummy and test "offline".
We should not forget to extend the documentation here: https://precice.org/couple-your-code-defining-mesh-connectivity.html
extras/bindings/fortran/include/precice/SolverInterfaceFortran.hpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Benjamin Uekermann <[email protected]>
Co-authored-by: Benjamin Uekermann <[email protected]>
Co-authored-by: Benjamin Uekermann <[email protected]>
Co-authored-by: Benjamin Uekermann <[email protected]>
Member
Author
|
I manually tested this using the Fortran and C solverdummies and it works fine. |
uekerman
approved these changes
Sep 14, 2021
uekerman
added a commit
to uekerman/precice.github.io
that referenced
this pull request
Sep 15, 2021
davidscn
pushed a commit
to precice/precice.github.io
that referenced
this pull request
Oct 11, 2021
* Add documentation for API isMeshConnectivityRequired According to precice/precice#1080 * Remove blank line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes of this PR
Adds access to the mesh requirements to the SolverInterface.
Closes #467
Motivation and additional information
Generating connectivity information and passing it to preCICE can be expensive, but preCICE does not always need full mesh connectivity for every mesh.
preCICE ignores API calls to define connectivity if this is not required, but there is no way for the solver to know this.
Thus, solvers/adapters have to be manually configured to skip the connectivity generation.
This PR proposes an API which allows a solver to get information for each mesh directly from preCICE.
Author's checklist
docs/changelog/if there are noteworthy changes.tools/formatting/check-formatand everything is formatted correctly.Reviewers' checklist