Build shared libraries by default#1077
Merged
fsimonis merged 4 commits intoprecice:developfrom Sep 13, 2021
Merged
Conversation
fsimonis
added
the
building
davidscn
reviewed
Sep 13, 2021
MakisH
approved these changes
Sep 13, 2021
Member
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
This will definitely and finally allow people to just run cmake .. && make, without having to first read the documentation. So, this is a huge improvement!
I do not consider this breaking, as the default is anyway not working at the moment. Moreover, all scripts that currently explicitly enable shared objects, will keep working.
We still need to update the documentation on the website.
Member
Is somebody already looking into this? Is there an issue? |
Member
I can do it. We have an issue now: precice/precice.github.io#83 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes of this PR
This PR changes the default build type of the preCICE library to
shared.Closes #801
Requires changes of the documentation.
Motivation and additional information
As discussed in #801, our current build configuration is not supported by default.
Having to explicitly change the build type to shared is tedious and unnecessary.
Do to our push towards minimal symbol visibility, using shared libraries should become the way to go in the future.
Supporting static libraries via CMake is still a long term goal.
Author's checklist
docs/changelog/if there are noteworthy changes.tools/formatting/check-formatand everything is formatted correctly.Reviewers' checklist