Draft: Waveform interpolation, read direction#1029
Closed
BenjaminRodenberg wants to merge 566 commits intoprecice:developfrom
Closed
Draft: Waveform interpolation, read direction#1029BenjaminRodenberg wants to merge 566 commits intoprecice:developfrom
BenjaminRodenberg wants to merge 566 commits intoprecice:developfrom
Conversation
BenjaminRodenberg
changed the title
BenjaminRodenberg
force-pushed
the
prototype_waveform_read_write
branch
from
6af9195 to
614e3ee
Compare
Merged
8 tasks
Contributor
Author
Contributor
Author
|
I created BenjaminRodenberg#1 as an intermediate milestone for this PR/branch. |
This was referenced Aug 23, 2021
uekerman
reviewed
Sep 2, 2021
Member
uekerman
left a comment
uekerman
left a comment
There was a problem hiding this comment.
I had a brief look.
It's a bit odd that you add parts of the preCICE API here. Why not having everything from here that lies in the time package into a separate PR? And doing the API changes and integration test afterwards?
13 tasks
8 tasks
8 tasks
7 tasks
* Improves how extraolation is configured. * Perform extrapolation in cplscheme::Extrapolation. * Store cplscheme::Extrapolation in cplscheme::CouplingData. * Perform interpolation in time::Waveform.
* Create Extrapolation class in cplscheme/impl for functionality. * Move all current functionality of Waveform into Extrapolation. Waveform is reserved for interpolation. * Store Extrapolation in CouplingData.
7 tasks
7 tasks
1 task
…consistent. Failing tests, breaking behavior of initializeData.
7 tasks
BenjaminRodenberg
added
the
breaking change
BenjaminRodenberg
added a commit
to BenjaminRodenberg/precice
that referenced
this pull request
Jul 3, 2022
10 tasks
Contributor
Author
|
Closing in favor of #1352 |
BenjaminRodenberg
added a commit
that referenced
this pull request
Jul 12, 2022
…1352) * Get tests and configs for serial implicit waveform interpolation from #1029. * Differentiate between received initial data and data (from advance). * Split data communication for SerialCouplingScheme and store initial data in waveform. * Move common functionality of serial and parallel coupling scheme into BiCouplingScheme. Co-authored-by: Benjamin Uekermann <[email protected]>
BenjaminRodenberg
added a commit
that referenced
this pull request
Jul 29, 2022
…1352) * Get tests and configs for serial implicit waveform interpolation from #1029. * Differentiate between received initial data and data (from advance). * Split data communication for SerialCouplingScheme and store initial data in waveform. * Move common functionality of serial and parallel coupling scheme into BiCouplingScheme. Co-authored-by: Benjamin Uekermann <[email protected]>
BenjaminRodenberg
added a commit
that referenced
this pull request
Aug 5, 2022
…1352) * Get tests and configs for serial implicit waveform interpolation from #1029. * Differentiate between received initial data and data (from advance). * Split data communication for SerialCouplingScheme and store initial data in waveform. * Move common functionality of serial and parallel coupling scheme into BiCouplingScheme. Co-authored-by: Benjamin Uekermann <[email protected]>
BenjaminRodenberg
added a commit
that referenced
this pull request
Aug 5, 2022
…1352) * Get tests and configs for serial implicit waveform interpolation from #1029. * Differentiate between received initial data and data (from advance). * Split data communication for SerialCouplingScheme and store initial data in waveform. * Move common functionality of serial and parallel coupling scheme into BiCouplingScheme. Co-authored-by: Benjamin Uekermann <[email protected]>
BenjaminRodenberg
added a commit
that referenced
this pull request
Aug 11, 2022
…1352) * Get tests and configs for serial implicit waveform interpolation from #1029. * Differentiate between received initial data and data (from advance). * Split data communication for SerialCouplingScheme and store initial data in waveform. * Move common functionality of serial and parallel coupling scheme into BiCouplingScheme. Co-authored-by: Benjamin Uekermann <[email protected]>
BenjaminRodenberg
added a commit
that referenced
this pull request
Aug 22, 2022
…1352) * Get tests and configs for serial implicit waveform interpolation from #1029. * Differentiate between received initial data and data (from advance). * Split data communication for SerialCouplingScheme and store initial data in waveform. * Move common functionality of serial and parallel coupling scheme into BiCouplingScheme. Co-authored-by: Benjamin Uekermann <[email protected]>
BenjaminRodenberg
added a commit
that referenced
this pull request
Sep 15, 2022
…1352) * Get tests and configs for serial implicit waveform interpolation from #1029. * Differentiate between received initial data and data (from advance). * Split data communication for SerialCouplingScheme and store initial data in waveform. * Move common functionality of serial and parallel coupling scheme into BiCouplingScheme. Co-authored-by: Benjamin Uekermann <[email protected]>
BenjaminRodenberg
added a commit
that referenced
this pull request
Nov 2, 2022
…1352) * Get tests and configs for serial implicit waveform interpolation from #1029. * Differentiate between received initial data and data (from advance). * Split data communication for SerialCouplingScheme and store initial data in waveform. * Move common functionality of serial and parallel coupling scheme into BiCouplingScheme. Co-authored-by: Benjamin Uekermann <[email protected]>
BenjaminRodenberg
added a commit
that referenced
this pull request
Nov 4, 2022
…1352) * Get tests and configs for serial implicit waveform interpolation from #1029. * Differentiate between received initial data and data (from advance). * Split data communication for SerialCouplingScheme and store initial data in waveform. * Move common functionality of serial and parallel coupling scheme into BiCouplingScheme. Co-authored-by: Benjamin Uekermann <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes of this PR
Todos
time::Wavefom.readScalarData(readData, vertexIDs, dataID, dt or t?)and otherreadAPI functions. Reading at arbitrary points inside window gives sample from interpolant (see Store from/toWaveform in DataContext BenjaminRodenberg/precice#1)Addnot needed.initializeWriteScalarData(writeData, vertexIDs, dataID)to allow initialization of starting value of write waveform (see Allow to initialize write data BenjaminRodenberg/precice#2)src/precice/tests/WaveformTests.cppto illustrate usage a7a0500<waveform order=1 or 2>). Must be optional! Implemented as subtag of<data:... />Merge Remove resetWrittenData #1157 (changes already included here)Make this PR independent from these changes. See discussion in Remove resetWrittenData #1157.experimental=off). Test should give same results for https://github.com/precice/precice/releases/tag/v2.3.0 and this PR. Merge tests intodevelopindependent from this PR.isReadDataAvailable()andisWriteDataRequired()?readVectorData,readBlockScalarDataandreadBlockVectorData.Features & Restrictions
initializeDatais called, this data will be used at the beginning of the first window. If noinitializeDatais used, the data at the beginning of the first window is zero.Motivation and additional information
Belongs to bigger work package #133. Implements first steps with some restrictions.
Author's checklist
docs/changelog/if there are noteworthy changes.tools/formatting/check-formatand everything is formatted correctly.Reviewers' checklist