Merged
Conversation
…allel TEST FAILS.
… Store current time window in lastTimeWindows.col(0), the one before in .col(1), the one before in .col(2).
…implify class layout.
BenjaminRodenberg
added
the
enhancement
old data is read only.
BenjaminRodenberg
added a commit
that referenced
this pull request
May 27, 2021
Contributor
Author
BenjaminRodenberg
left a comment
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
I went through the PR and identified open todos and minor fixes that have still to be done.
Contributor
Author
|
@uekerman Ready for the next review. We have a test now, which ensures that acceleration and extrapolation are applied correctly. There are a few minor todos from my perspective. Rest is ready to merge, as far as I see it. Open Todos:
|
uekerman
approved these changes
Jun 1, 2021
Member
uekerman
left a comment
uekerman
left a comment
There was a problem hiding this comment.
Minor things, otherwise good to go. Please merge when done.
And don't forget the changelog.
Co-authored-by: Benjamin Uekermann <[email protected]>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes of this PR
This PR will move all functionality related to time windows and time steps into an independent package. This can be seen as a follow-up PR to #876.
Motivation and additional information
This PR belongs to the bigger goal of implementing waveform relaxation in preCICE. See #133
Author's checklist
docs/changelog/if there are noteworthy changes.tools/formatting/check-formatand everything is formatted correctly.Reviewers' checklist