Skip to content

OpenFOAM9-specific changes#222

Merged
MakisH merged 3 commits intoprecice:OpenFOAM9from
jheylmun:OpenFOAMdev
Mar 11, 2022
Merged

OpenFOAM9-specific changes#222
MakisH merged 3 commits intoprecice:OpenFOAM9from
jheylmun:OpenFOAMdev

Conversation

@MakisH
Copy link
Copy Markdown
Member

@MakisH MakisH commented Feb 23, 2022

This is a duplicate of #221, which I merged by mistake (GitHub CLI (gh pr checkout) does not currently seem to handle all cases of having a PR between branches of the same name, which made me accidentally push some updates to our OpenFOAMdev, when it should have pushed to jheylmun/OpenFOAMdev. See maybe cli/cli#4968 or cli/cli#2189).

@jheylmun thanks a lot for the contribution! Could you please also format the code? I can also do this after merging.
@engenegr does this agree with your changes for OpenFOAM9?

This closes #200.

TODO list:

  • I updated the documentation in docs/ -> done in develop, 5800f21
  • I added a changelog entry in changelog-entries/ (create directory if missing) -> not needed
  • I fixed the formatting with ./tools/format-code.sh

@MakisH
Copy link
Copy Markdown
Member Author

MakisH commented Feb 23, 2022

I let a custom build for OpenFOAM 9 run, it looks like we would need to do some updates in the configuration files of our FSI tutorials as well (probably renaming solver to motionSolver):

--> FOAM FATAL IO ERROR: 
keyword motionSolver is undefined in dictionary "/home/runner/work/openfoam-adapter/openfoam-adapter/tutorials/quickstart/fluid-openfoam/constant/dynamicMeshDict"

The flow-over-heated-plate and partitioned-pipe seem to run fine.

@evd0kim
Copy link
Copy Markdown

evd0kim commented Feb 23, 2022

I see relevant changes however it seems that my OpenFOAM working environment is not 9 already so I have some other changes here and there.

I have reason for that since our software runs on later commits which incorporates critical bugfixes. They weren't backported to 9.

So I am sorry. My opinion is that this PR should be fine.

@MakisH
Copy link
Copy Markdown
Member Author

MakisH commented Mar 11, 2022

Thanks a lot once again for the contribution! I added a note about renaming solver to motionSolver in precice/tutorials#265. I also documented this in the compatibilty page: https://precice.org/adapter-openfoam-support.html

We are planning for a bugfix release soon, I will add a release archive then (potentially also already in v1.1.0).

@MakisH MakisH merged commit 3dc52c2 into precice:OpenFOAM9 Mar 11, 2022
@MakisH MakisH added this to the v1.2.0 milestone Sep 19, 2022
MakisH added a commit that referenced this pull request Nov 19, 2022
MakisH added a commit that referenced this pull request Nov 19, 2022
MakisH added a commit that referenced this pull request Nov 19, 2022
MakisH added a commit that referenced this pull request Nov 19, 2022
davidscn pushed a commit that referenced this pull request Jun 20, 2023
MakisH added a commit that referenced this pull request Apr 26, 2024
jmozmoz pushed a commit to jmozmoz/openfoam-adapter that referenced this pull request Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants