Conversation
|
I let a custom build for OpenFOAM 9 run, it looks like we would need to do some updates in the configuration files of our FSI tutorials as well (probably renaming The flow-over-heated-plate and partitioned-pipe seem to run fine. |
|
I see relevant changes however it seems that my OpenFOAM working environment is not I have reason for that since our software runs on later commits which incorporates critical bugfixes. They weren't backported to So I am sorry. My opinion is that this PR should be fine. |
|
Thanks a lot once again for the contribution! I added a note about renaming We are planning for a bugfix release soon, I will add a release archive then (potentially also already in v1.1.0). |
Co-authored-by: Jeff Heylmun <[email protected]>
Co-authored-by: Jeff Heylmun <[email protected]>
Co-authored-by: Jeff Heylmun <[email protected]>
Co-authored-by: Jeff Heylmun <[email protected]>
Co-authored-by: Jeff Heylmun <[email protected]>
Co-authored-by: Jeff Heylmun <[email protected]>
Co-authored-by: Jeff Heylmun <[email protected]>
This is a duplicate of #221, which I merged by mistake (GitHub CLI (
gh pr checkout) does not currently seem to handle all cases of having a PR between branches of the same name, which made me accidentally push some updates to ourOpenFOAMdev, when it should have pushed tojheylmun/OpenFOAMdev. See maybe cli/cli#4968 or cli/cli#2189).@jheylmun thanks a lot for the contribution! Could you please also format the code? I can also do this after merging.
@engenegr does this agree with your changes for OpenFOAM9?
This closes #200.
TODO list:
docs/-> done indevelop, 5800f21changelog-entries/(create directory if missing) -> not needed./tools/format-code.sh