Update preCICE API calls for precice:develop#51
Merged
IshaanDesai merged 32 commits intodevelopfrom Aug 28, 2023
Merged
Conversation
Member
|
Thanks for already opening the v3 update PR! As far as I know, the function
The unit tests fail because we install pyprecice as part of the micro-manager installation, which then pulls |
… initial data to preCICE
Member
|
As stated in #54, the Micro Manager can no longer write initial data to preCICE. The |
IshaanDesai
approved these changes
Aug 28, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the micro-manager preCICE version to the current API from the python-bindings.
One Problem I am currently facing is requiring initial data. The Micro Manager uses
self._participant.get_mesh_vertices_and_idsto get the number of local micro sims. However, now thatinitialize_dataandinitializeis justinitializewe can't do:initializeget_mesh_vertices_and_idsinitialize_dataas we did before.
Related to that problem are probably the changes in the precice-config where some precice-error occured with
but ran fine with initialize="no".
These changes are just adapting the new preCICE API. But it would be interesting to rethink if a hard separation of scalar and vector data is necessary, now that the preCICE API has only one read and write data function.
Also the tests currently fail due to an error in installing the python bindings on the develop container, but I do not see much of a difference in installing the bindings than in the python-bindings tests. The solverdummies run locally with the develop version of precice and the python-bindings.