Add support for waveform relaxation with linear interpolation.#35
Add support for waveform relaxation with linear interpolation.#35BenjaminRodenberg merged 75 commits intoCoupledProblems2019from
Conversation
added docstring to explain call-by-reference update of u_n
…only working if parallel to y axis). Clearly reduces error reported in https://github.com/precice/tutorials/issues/13
…rocessed via preCICE.
…ation count) as without WR and without subcycling.
* Updates README.md * Creates a dummy precice package for successful testing
| import numpy as np | ||
| from .config import Config | ||
| from .checkpointing import Checkpoint | ||
| from .solverstate import SolverState |
There was a problem hiding this comment.
I guess this "." notation here is standard and only looks weird to me. When should that be used?
There was a problem hiding this comment.
The . indicates a relative import (see https://realpython.com/absolute-vs-relative-python-imports/). In this project it was the first thing that came to my mind. As far as I understand an absolute import should also work (instead of from .config import Config one can use the statement from fenicsadapter.config import Config).
As far as I understand the article above, the main reasons for using relative imports are a better readability and more flexibility when it comes to moving packages/subpackages within the project. This means, we could indeed switch from relative to absolute imports, but I think in the end it does not really matter.
2 participants
This PR collects all the changes that are relevant to add waveform relaxation support in the FEniCS adapter.
TemperaturebecomesTemperature1,Temperature2,...Be aware that this approach is not compatible with the original preCICE API and experimental. In
waveform_bindings.pyAPI functions likereadBlockScalarDataare extended with the additional parametertime(see here).For example usage of the modified adapter, refer to precice/tutorials#30.