Add check for mesh connectivity requirement before computing mesh edges#138
Closed
IshaanDesai wants to merge 1 commit intodevelopfrom
Closed
Add check for mesh connectivity requirement before computing mesh edges#138IshaanDesai wants to merge 1 commit intodevelopfrom
IshaanDesai wants to merge 1 commit intodevelopfrom
Conversation
Member
|
Please be aware that this means that the FEniCS adapter can no longer be used with preCICE < v2.3. |
Contributor
Is it possible to only perform this check, if the preCICE version is recent enough and skip the check (and raise a warning?) if preCICE is < 2.3? pyprecice allows you to query the version of the bindings. So you should be able to check the version and act correspondingly inside the adapter. |
Member
Author
|
Check added in #153 |
BenjaminRodenberg
added a commit
that referenced
this pull request
Sep 28, 2023
* Remove API functions that are removed in v3.0.0. Fix data initialization. * Forward dt to python bindings. * Set mesh connectivity information only if it is required. Closes #138 * Update tests * Update links of contributors * Update CHANGELOG.md * Call checkpointing functions from the interface * Change required version of pyprecice to >=3.0.0.0 * Comment out nearest projection volume coupling. --------- Co-authored-by: Ishaan Desai <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In precice/precice#1080 the API function
isMeshConnectivityRequired()was added to check if mesh connectivity information is required by preCICE. This API function is now used to check whether the mesh edge computation is necessary.