Conversation
|
Test case for temperature: https://github.com/boris-martin/ccx_heat_2d_test (On a side note, this is a case that spontanously reproduces issue #86 in both 2D and 3D, which I struggled to reproduce before. Life is weird that way) |
IshaanDesai
left a comment
IshaanDesai
left a comment
There was a problem hiding this comment.
This is a really significant improvement to the 2D-3D case handling capability and is a general and clean solution! Great work 👍 I did not look at each and every line of the change, but I ran the perpendicular-flap tutorial case with OpenFOAM and SU2 and the results are as expected.
|
This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there: |
|
Hi @boris-martin |
|
@uekerman Exactly, I was trying to set up this case then realized all the missing features on the adapter and started this PR. |
* Improved error message (for missing mesh) (#88) * Added error message for missing faces mesh * Improved error message for missing nodes mesh * 2D simulations major overhaul (#92) Fixed 2D simulations being unusable with Temperature BC. Arbitrary number of elements on the Z-axis is now allowed and handled assuming data independant of the Z-axis. * Added Pressure ExchangeData, hexaedral elements and Modal Dynamic Modus (#91) * Added Pressure ExchangeData, hexaedral elements and Modal Dynamic Modus * Update dyna_precice.c Co-authored-by: Matthias Freimuth <[email protected]> Co-authored-by: Boris Martin <[email protected]> * format * Added warning of broken implicit coupling when using modal dynamic simulations * Fixed mesh configuration 2D coupling with Face meshes (#94) * Fixed mesh config for face mesh * Removed dead code * Fixed missing include * Fixed crash when using face meshes and element IDs don't start to 0 (#95) * Fixed crashing simulation when using face meshes and element IDs don't start to 0 * Typo Co-authored-by: Ishaan Desai <[email protected]> * Typo Co-authored-by: Ishaan Desai <[email protected]> * Typo Co-authored-by: Ishaan Desai <[email protected]> * Update adapter/CCXHelpers.h Co-authored-by: Ishaan Desai <[email protected]> * format * reverted fallow-argument-mismatch * format Co-authored-by: Ishaan Desai <[email protected]> * Revert "Fixed crash when using face meshes and element IDs don't start to 0 (#95)" (#96) This reverts commit 9cfc0cf. * Update packaging script to Ubuntu 22.04 LTS (#98) * added ubuntu 22.04 to the list of OSes in Github action * updated to 2 Ubuntu LTS only, added fflags * fixed wrong distribution name * added preivous Ubuntu non-LTS * fixd missing os * typo * removed non LTS * Fixed face mesh config(correct PR) (#97) * Fixed crashing simulation when using face meshes and element IDs don't start to 0 * Typo Co-authored-by: Ishaan Desai <[email protected]> * Typo Co-authored-by: Ishaan Desai <[email protected]> * Typo Co-authored-by: Ishaan Desai <[email protected]> * Update adapter/CCXHelpers.h Co-authored-by: Ishaan Desai <[email protected]> Co-authored-by: Ishaan Desai <[email protected]> * format * format * restored script * Fixed implicit coupling in modal dynamic simulation. (#99) * Fixed missing checkpointing * fixed extra output in implicit coupling * removed deprecated warnings * Fixed crash when freeing unused pointers (#102) * init NULL pointers * Enable Static Step for FSI (#101) * Update ccx_2.19.c Enable basic Static Step * Update ccx_2.19.c * Update ccx_2.19.c * Add error messages when reading invalid data in modal dynamic simulations (#103) * registering modal dynamic * added forbidden reading types to modal dynamic sims * added actual error * Update adapter/PreciceInterface.c Co-authored-by: Gerasimos Chourdakis <[email protected]> * Update adapter/PreciceInterface.h Co-authored-by: Gerasimos Chourdakis <[email protected]> Co-authored-by: Gerasimos Chourdakis <[email protected]> * basic infrastructure for proper checkpointingin dyna_precice * seemingly working implict + subcycling modal dynamic simulations * Prototype output buffer * added C API * added missing function * improved Buffer * Actual usage of the buffer, seemingly working * added short description of the buffer mechanism * cleanup * refactoring * format * removed dead code * renamed for consistency * no longer asking for length when loading data * cleanup * documentation * removed apparently useless memcpy (#104) * Make read/write data name parsing consistent (#108) * Update for CalculiX v2.20 (#109) Co-authored-by: Boris Martin <[email protected]> Co-authored-by: MatthiasFreimuth <[email protected]> Co-authored-by: Matthias Freimuth <[email protected]> Co-authored-by: Boris Martin <[email protected]> Co-authored-by: Ishaan Desai <[email protected]> Co-authored-by: Kyle Davis <[email protected]>
|
This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there: |
4 participants
Context
Currently, simulations in Quasi2D-3D are limited to meshes where there is exactly 2 points in 3D space for a 2D point: one with z=0 and one with z=1. In particular, this forbids the use of 2nd order elements. Furthermore, mapping from 3D to 2D is always consistent but mapping from 2D to 3D is conservative. For instance, reading forces and sending displacements works but the opposite is broken. Having a Temperature Dirichlet BC is not possible (it would be divided by 2)
Approach
Mapping is reworked to allow for a variable number of 3D points per 2D point. Both consistent and conservative mappings are implemented. Number of 3D points on a 2D point is used to compute average in a consistent write, or to split loads in conservate reads.
Code is refactored to limit the number of 2D-specific code inside
PreciceInterface.c(which is 100 lines shorter!)New features
Checks
done, but results inconsistent. Investigation ongoing.Shell elements give good results, unlike the plane stress elements. Apparently 1st order Shell expands into C38DI whereas plane stress expand into C3D, which probably explains it. Anyway, 2D coupling with 2D elements works, in terms of codeFuture work