Skip to content

Comments

refactor(diff): make oldProps diffing more compact (#5004)#5019

Merged
JoviDeCroock merged 1 commit intov10.xfrom
backport-optimization
Feb 12, 2026
Merged

refactor(diff): make oldProps diffing more compact (#5004)#5019
JoviDeCroock merged 1 commit intov10.xfrom
backport-optimization

Conversation

@JoviDeCroock
Copy link
Member

  • refactor(diff): make oldProps diffing more compact

  • test(render): check if children is being set on rerenders


Land #5004 in v10

* refactor(diff): make oldProps diffing more compact

* test(render): check if children is being set on rerenders

---------

Co-authored-by: Ali Garajian <[email protected]>
@github-actions
Copy link

github-actions bot commented Feb 12, 2026

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -0% - +1% (-1.76ms - +10.19ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.03ms - +0.03ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +2% (-0.51ms - +1.03ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -1% - +0% (-0.21ms - +0.06ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +2% (-0.40ms - +1.19ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -1% - +9% (-0.02ms - +0.17ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +1% (-0.08ms - +0.46ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -5% - +4% (-1.45ms - +1.22ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -5% - +8% (-0.34ms - +0.54ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -4% - +2% (-0.05ms - +0.02ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local893.31ms - 904.01ms-unsure 🔍
-0% - +1%
-1.76ms - +10.19ms
preact-main891.79ms - 897.10msunsure 🔍
-1% - +0%
-10.19ms - +1.76ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.20ms - 19.20ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main19.20ms - 19.20msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.53ms - 16.58ms-unsure 🔍
-0% - +0%
-0.03ms - +0.03ms
preact-main16.54ms - 16.58msunsure 🔍
-0% - +0%
-0.03ms - +0.03ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.56ms - 1.56ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-main1.56ms - 1.56msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local59.98ms - 61.18ms-unsure 🔍
-1% - +2%
-0.51ms - +1.03ms
preact-main59.84ms - 60.80msunsure 🔍
-2% - +1%
-1.03ms - +0.51ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local6.47ms - 7.08ms-unsure 🔍
-5% - +8%
-0.34ms - +0.54ms
preact-main6.36ms - 6.99msunsure 🔍
-8% - +5%
-0.54ms - +0.34ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.46ms - 16.54ms-unsure 🔍
-1% - +0%
-0.21ms - +0.06ms
preact-main16.45ms - 16.71msunsure 🔍
-0% - +1%
-0.06ms - +0.21ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.72ms - 3.72ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.72ms - 3.72msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #5355
  • Commit: 49a8019

duration

VersionAvg timevs preact-localvs preact-main
preact-local57.46ms - 58.65ms-unsure 🔍
-1% - +2%
-0.40ms - +1.19ms
preact-main57.12ms - 58.19msunsure 🔍
-2% - +1%
-1.19ms - +0.40ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.01ms - 3.01ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.01ms - 3.01msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local25.51ms - 26.32ms-unsure 🔍
-2% - +3%
-0.40ms - +0.67ms
preact-main25.44ms - 26.12msunsure 🔍
-3% - +2%
-0.67ms - +0.40ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local31.60ms - 32.90ms-unsure 🔍
-2% - +4%
-0.56ms - +1.20ms
preact-main31.34ms - 32.52msunsure 🔍
-4% - +2%
-1.20ms - +0.56ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local32.33ms - 33.53ms-unsure 🔍
-1% - +4%
-0.45ms - +1.25ms
preact-main31.93ms - 33.12msunsure 🔍
-4% - +1%
-1.25ms - +0.45ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local25.51ms - 25.88ms-unsure 🔍
-2% - +1%
-0.48ms - +0.21ms
preact-main25.54ms - 26.12msunsure 🔍
-1% - +2%
-0.21ms - +0.48ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local24.18ms - 25.42ms-unsure 🔍
-5% - +2%
-1.37ms - +0.46ms
preact-main24.58ms - 25.93msunsure 🔍
-2% - +6%
-0.46ms - +1.37ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local21.40ms - 21.86ms-unsure 🔍
-1% - +2%
-0.30ms - +0.33ms
preact-main21.40ms - 21.84msunsure 🔍
-2% - +1%
-0.33ms - +0.30ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 240
  • Built by: CI #5355
  • Commit: 49a8019

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.89ms - 2.05ms-unsure 🔍
-1% - +9%
-0.02ms - +0.17ms
preact-main1.85ms - 1.95msunsure 🔍
-8% - +1%
-0.17ms - +0.02ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.00ms - 1.04ms-unsure 🔍
-4% - +2%
-0.05ms - +0.02ms
preact-main1.01ms - 1.06msunsure 🔍
-2% - +5%
-0.02ms - +0.05ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local33.04ms - 33.47ms-unsure 🔍
-0% - +1%
-0.08ms - +0.46ms
preact-main32.91ms - 33.22msunsure 🔍
-1% - +0%
-0.46ms - +0.08ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.25ms - 1.25ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.25ms - 1.25msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local28.84ms - 30.66ms-unsure 🔍
-5% - +4%
-1.45ms - +1.22ms
preact-main28.89ms - 30.83msunsure 🔍
-4% - +5%
-1.22ms - +1.45ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.97ms - 2.98ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-main2.97ms - 2.98msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms
-

tachometer-reporter-action v2 for CI

@github-actions
Copy link

Size Change: -94 B (-0.12%)

Total Size: 79.3 kB

Filename Size Change
dist/preact.js 4.76 kB -14 B (-0.29%)
dist/preact.min.js 4.78 kB -16 B (-0.33%)
dist/preact.min.module.js 4.79 kB -14 B (-0.29%)
dist/preact.min.umd.js 4.81 kB -15 B (-0.31%)
dist/preact.mjs 4.78 kB -11 B (-0.23%)
dist/preact.module.js 4.78 kB -11 B (-0.23%)
dist/preact.umd.js 4.81 kB -13 B (-0.27%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 4.22 kB
compat/dist/compat.mjs 4.14 kB
compat/dist/compat.module.js 4.14 kB
compat/dist/compat.umd.js 4.28 kB
debug/dist/debug.js 3.85 kB
debug/dist/debug.mjs 3.85 kB
debug/dist/debug.module.js 3.85 kB
debug/dist/debug.umd.js 3.93 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.mjs 274 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 346 B
hooks/dist/hooks.js 1.54 kB
hooks/dist/hooks.mjs 1.57 kB
hooks/dist/hooks.module.js 1.57 kB
hooks/dist/hooks.umd.js 1.61 kB
jsx-runtime/dist/jsxRuntime.js 1.01 kB
jsx-runtime/dist/jsxRuntime.mjs 985 B
jsx-runtime/dist/jsxRuntime.module.js 985 B
jsx-runtime/dist/jsxRuntime.umd.js 1.08 kB
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 477 B
test-utils/dist/testUtils.module.js 477 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@JoviDeCroock JoviDeCroock merged commit 387d8f2 into v10.x Feb 12, 2026
14 checks passed
@JoviDeCroock JoviDeCroock deleted the backport-optimization branch February 12, 2026 18:50
@JoviDeCroock JoviDeCroock mentioned this pull request Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants