Skip to content

Comments

Forwardport fixes from v10#5008

Merged
JoviDeCroock merged 2 commits intomainfrom
forwardport-fixes
Feb 1, 2026
Merged

Forwardport fixes from v10#5008
JoviDeCroock merged 2 commits intomainfrom
forwardport-fixes

Conversation

@JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Jan 31, 2026

No description provided.

@JoviDeCroock
Resolve some suspense crashes (#4999)
d143a6e 
* Fix suspense crash

* Prevent unmounted suspended vnodes from rendering

Before this when we unmounted a vnode which was in a suspended state
it was possible to cause this to render while being unmounted.
One disturbing thing is that I wanted to check
vnode._component._onResolve
in the options.unmount hook, this however was not possible because
somehow the reference to `_component` isn't being updated on the
vnode that's actually unmounting. For this reason I opted to
use a separate flag.
@JoviDeCroock
Avoid scheduling suspense state udpates (#5006)
8d31859
@github-actions
Copy link

github-actions bot commented Jan 31, 2026 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +0% (-5.91ms - +3.13ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.01ms - +0.06ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +1% (-1.37ms - +0.49ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -2% - +5% (-0.29ms - +0.80ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -2% - +2% (-1.13ms - +1.02ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -5% - +3% (-0.10ms - +0.06ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +2% (-0.21ms - +0.62ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -5% - +4% (-1.51ms - +1.15ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -5% - +6% (-0.37ms - +0.43ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • text-update: slower ❌ 0% - 6% (0.00ms - 0.06ms)
    preact-local vs preact-main
  • todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local812.48ms - 818.79ms-unsure 🔍
-1% - +0%
-5.91ms - +3.13ms
preact-main813.78ms - 820.27msunsure 🔍
-0% - +1%
-3.13ms - +5.91ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.04ms - 19.04ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main19.04ms - 19.04msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.51ms - 16.56ms-unsure 🔍
-0% - +0%
-0.01ms - +0.06ms
preact-main16.49ms - 16.53msunsure 🔍
-0% - +0%
-0.06ms - +0.01ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.54ms - 1.55ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.54ms - 1.55msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local59.45ms - 60.65ms-unsure 🔍
-2% - +1%
-1.37ms - +0.49ms
preact-main59.78ms - 61.21msunsure 🔍
-1% - +2%
-0.49ms - +1.37ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local6.74ms - 7.25ms-unsure 🔍
-5% - +6%
-0.37ms - +0.43ms
preact-main6.66ms - 7.27msunsure 🔍
-6% - +5%
-0.43ms - +0.37ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.27ms - 17.30ms-unsure 🔍
-2% - +5%
-0.29ms - +0.80ms
preact-main16.35ms - 16.71msunsure 🔍
-5% - +2%
-0.80ms - +0.29ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.72ms - 3.73ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.72ms - 3.72msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #5329

  • Commit: 8d31859

duration

VersionAvg timevs preact-localvs preact-main
preact-local58.94ms - 60.61ms-unsure 🔍
-2% - +2%
-1.13ms - +1.02ms
preact-main59.16ms - 60.51msunsure 🔍
-2% - +2%
-1.02ms - +1.13ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.99ms - 2.99ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main2.99ms - 2.99msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local25.57ms - 26.23ms-unsure 🔍
-2% - +2%
-0.58ms - +0.42ms
preact-main25.60ms - 26.36msunsure 🔍
-2% - +2%
-0.42ms - +0.58ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local31.99ms - 33.05ms-unsure 🔍
-3% - +1%
-1.04ms - +0.40ms
preact-main32.35ms - 33.33msunsure 🔍
-1% - +3%
-0.40ms - +1.04ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local33.59ms - 34.38ms-unsure 🔍
-0% - +3%
-0.04ms - +1.10ms
preact-main33.04ms - 33.86msunsure 🔍
-3% - +0%
-1.10ms - +0.04ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local26.46ms - 26.92ms-unsure 🔍
-1% - +2%
-0.14ms - +0.43ms
preact-main26.38ms - 26.71msunsure 🔍
-2% - +1%
-0.43ms - +0.14ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local25.90ms - 27.31ms-unsure 🔍
-6% - +2%
-1.63ms - +0.51ms
preact-main26.36ms - 27.97msunsure 🔍
-2% - +6%
-0.51ms - +1.63ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local21.89ms - 22.48ms-unsure 🔍
-1% - +3%
-0.21ms - +0.57ms
preact-main21.75ms - 22.26msunsure 🔍
-3% - +1%
-0.57ms - +0.21ms		-
text-update
  • Browser: chrome-headless
  • Sample size: 220
  • Built by: CI #5329

  • Commit: 8d31859

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.90ms - 2.04ms-unsure 🔍
-5% - +3%
-0.10ms - +0.06ms
preact-main1.95ms - 2.03msunsure 🔍
-3% - +5%
-0.06ms - +0.10ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.01ms - 1.05ms-slower ❌
0% - 6%
0.00ms - 0.06ms
preact-main0.99ms - 1.02msfaster ✔
1% - 5%
0.00ms - 0.06ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local30.98ms - 31.74ms-unsure 🔍
-1% - +2%
-0.21ms - +0.62ms
preact-main30.98ms - 31.33msunsure 🔍
-2% - +1%
-0.62ms - +0.21ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.25ms - 1.25ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main1.25ms - 1.25msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local30.44ms - 32.20ms-unsure 🔍
-5% - +4%
-1.51ms - +1.15ms
preact-main30.50ms - 32.50msunsure 🔍
-4% - +5%
-1.15ms - +1.51ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.95ms - 2.96ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-main2.95ms - 2.96msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms		-

tachometer-reporter-action v2 for CI

@github-actions
Copy link

github-actions bot commented Jan 31, 2026

Size Change: +79 B (+0.17%)

Total Size: 47.6 kB

Filename Size Change
compat/dist/compat.js 3.95 kB +28 B (+0.71%)
compat/dist/compat.mjs 3.88 kB +25 B (+0.65%)
compat/dist/compat.umd.js 4 kB +26 B (+0.65%)
ℹ️ View Unchanged
Filename Size
debug/dist/debug.js 3.91 kB
debug/dist/debug.mjs 3.91 kB
debug/dist/debug.umd.js 3.99 kB
devtools/dist/devtools.js 263 B
devtools/dist/devtools.mjs 273 B
devtools/dist/devtools.umd.js 348 B
dist/preact.js 4.7 kB
dist/preact.mjs 4.71 kB
dist/preact.umd.js 4.77 kB
hooks/dist/hooks.js 1.53 kB
hooks/dist/hooks.mjs 1.56 kB
hooks/dist/hooks.umd.js 1.6 kB
jsx-runtime/dist/jsxRuntime.js 892 B
jsx-runtime/dist/jsxRuntime.mjs 861 B
jsx-runtime/dist/jsxRuntime.umd.js 966 B
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 473 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@coveralls
Copy link

coveralls commented Jan 31, 2026

Coverage Status

coverage: 99.538% (+0.1%) from 99.443%
when pulling 8d31859 on forwardport-fixes
into 5358f32 on main.

@JoviDeCroock JoviDeCroock merged commit 6d29e2c into main Feb 1, 2026
15 checks passed
@JoviDeCroock JoviDeCroock deleted the forwardport-fixes branch February 1, 2026 08:15
@JoviDeCroock JoviDeCroock mentioned this pull request Feb 1, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rschristian rschristian rschristian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JoviDeCroock @coveralls @rschristian