refactor(children): remove redundant assignment to oldVNode#4956
Merged
rschristian merged 1 commit intopreactjs:mainfrom Nov 16, 2025
Merged
refactor(children): remove redundant assignment to oldVNode#4956rschristian merged 1 commit intopreactjs:mainfrom
rschristian merged 1 commit intopreactjs:mainfrom
Conversation
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Resultscreate10kduration
usedJSHeapSize
filter-listduration
usedJSHeapSize
hydrate1kduration
usedJSHeapSize
many-updatesduration
usedJSHeapSize
replace1kduration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-updateduration
usedJSHeapSize
tododuration
usedJSHeapSize
update10th1kduration
usedJSHeapSize
|
Member
|
This one I'm less sure of, looks a little suspect looking at line 253/254 & this commit: b4a1cc2 Also, rebasing before opening PRs is generally appreciated. This has 6 commits associated with it because you haven't. |
Contributor
Author
|
@rschristian sorry about the extra commits, won't happen again I can see your concern, but I'm going through every branch of code after that assignment and it seems everything would be fine without it. |
Member
No worries, and you can rebase this yet. Just makes it a bit easier for us is all.
Looks a bit suspect to me yet, would need to look into it more later this week
In a perfect world that'd be enough, but in reality, test suites can have gaps. That's certainly a good sign though. |
AhmedEjaz-Frontend
approved these changes
Nov 13, 2025
rschristian
approved these changes
Nov 16, 2025
JoviDeCroock
pushed a commit
that referenced
this pull request
Nov 29, 2025
Co-authored-by: Ali Garajian <[email protected]>
JoviDeCroock
added a commit
that referenced
this pull request
Nov 29, 2025
* refactor(children): remove redundant assignment to childVNode (#4951) * refactor(children): remove redundant assignment to childVNode * refactor(children): use key instead of childVNode.key --------- Co-authored-by: Ali Garajian <[email protected]> * refactor(diff): no need to reset props and context when creating component (#4954) * refactor(children): remove redundant assignment to childVNode * refactor(children): use key instead of childVNode.key * refactor(diff): no need to reset props and context when creating component --------- Co-authored-by: Ali Garajian <[email protected]> * refactor(children): remove redundant assignment to oldVNode (#4956) Co-authored-by: Ali Garajian <[email protected]> * refactor(diff): set oldProps default value on declaration (#4959) --------- Co-authored-by: Ali Garajian <[email protected]> Co-authored-by: Ali Garajian <[email protected]>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.