Conversation
📊 Tachometer Benchmark ResultsSummaryA summary of the benchmark results will show here once they finish. ResultsThe full results of your benchmarks will show here once they finish. |
|
On a semi-related note, the Tachometer comment will keep appearing for PRs against So it'll be a bit noisy and there will be some empty comments like above, but we'll still get reporting when the benches run, which seems preferable to disabling the thing on branches other than I don't know what else to do here besides write a script to start querying GH's API manually which I'm not exactly thrilled about nor enthusiastic to do; feels like there's a really weird gap in the event payload data here. I opened a couple threads on their site-wide discussions repo, we'll see if that goes anywhere I guess. |
Our benchmarks action is failing on PRs opened against v10.x as we're not running the "CI" workflow on push. The "CI" workflow triggers "Build & Test" which uploads assets that future commits will compare against; the merge commits we're making at the moment aren't associated with a workflow run, ergo, the action will fail to download the artifact for comparison.
Edit: Or at least that's what I think is happening. Fingers crossed?