Skip to content

Ensure memoized components re-render after errors #4880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoviDeCroock merged 2 commits into from
Aug 9, 2025
Merged

Ensure memoized components re-render after errors #4880

JoviDeCroock merged 2 commits into from
Aug 9, 2025

Conversation

@JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Aug 8, 2025

Fixes #3449

@github-actions
Copy link

github-actions bot commented Aug 8, 2025 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

⏳ Benchmarks are currently running. Results below are out of date.

duration

  • create10k: unsure 🔍 -0% - +1% (-1.91ms - +5.51ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -2% - +1% (-0.28ms - +0.09ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +2% (-0.94ms - +1.17ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -2% - +1% (-0.29ms - +0.09ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +2% (-0.50ms - +1.16ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -2% - +5% (-0.04ms - +0.09ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +2% (-0.12ms - +0.51ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -5% - +1% (-1.46ms - +0.41ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -6% - +6% (-0.38ms - +0.37ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +1% (-0.03ms - +0.02ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -4% - +3% (-0.04ms - +0.03ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main

Results

⏳ Benchmarks are currently running. Results below are out of date.
create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local947.15ms - 952.71ms-unsure 🔍
-0% - +1%
-1.91ms - +5.51ms
preact-main945.67ms - 950.58msunsure 🔍
-1% - +0%
-5.51ms - +1.91ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.03ms - 19.03ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main19.03ms - 19.03msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.44ms - 16.49ms-unsure 🔍
-2% - +1%
-0.28ms - +0.09ms
preact-main16.38ms - 16.74msunsure 🔍
-1% - +2%
-0.09ms - +0.28ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.53ms - 1.53ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.53ms - 1.53msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local65.50ms - 66.83ms-unsure 🔍
-1% - +2%
-0.94ms - +1.17ms
preact-main65.24ms - 66.86msunsure 🔍
-2% - +1%
-1.17ms - +0.94ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local5.94ms - 6.47ms-unsure 🔍
-6% - +6%
-0.38ms - +0.37ms
preact-main5.94ms - 6.48msunsure 🔍
-6% - +6%
-0.37ms - +0.38ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.24ms - 16.54ms-unsure 🔍
-2% - +1%
-0.29ms - +0.09ms
preact-main16.38ms - 16.60msunsure 🔍
-1% - +2%
-0.09ms - +0.29ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.72ms - 3.72ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.72ms - 3.72msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #5021

  • Commit: bacacda

duration

VersionAvg timevs preact-localvs preact-main
preact-local60.23ms - 61.40ms-unsure 🔍
-1% - +2%
-0.50ms - +1.16ms
preact-main59.90ms - 61.08msunsure 🔍
-2% - +1%
-1.16ms - +0.50ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.08ms - 3.12ms-unsure 🔍
-1% - +1%
-0.03ms - +0.02ms
preact-main3.08ms - 3.12msunsure 🔍
-1% - +1%
-0.02ms - +0.03ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local25.04ms - 25.76ms-unsure 🔍
-1% - +3%
-0.23ms - +0.76ms
preact-main24.80ms - 25.48msunsure 🔍
-3% - +1%
-0.76ms - +0.23ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local31.58ms - 32.53ms-unsure 🔍
-3% - +1%
-1.00ms - +0.33ms
preact-main31.93ms - 32.86msunsure 🔍
-1% - +3%
-0.33ms - +1.00ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local29.20ms - 29.93ms-unsure 🔍
-2% - +2%
-0.55ms - +0.49ms
preact-main29.22ms - 29.96msunsure 🔍
-2% - +2%
-0.49ms - +0.55ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local25.94ms - 26.70ms-unsure 🔍
-3% - +1%
-0.88ms - +0.17ms
preact-main26.32ms - 27.03msunsure 🔍
-1% - +3%
-0.17ms - +0.88ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local22.71ms - 23.76ms-unsure 🔍
-3% - +4%
-0.62ms - +0.81ms
preact-main22.65ms - 23.63msunsure 🔍
-3% - +3%
-0.81ms - +0.62ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local20.74ms - 21.58ms-unsure 🔍
-2% - +4%
-0.37ms - +0.78ms
preact-main20.56ms - 21.35msunsure 🔍
-4% - +2%
-0.78ms - +0.37ms		-
text-update
  • Browser: chrome-headless
  • Sample size: 130
  • Built by: CI #5021

  • Commit: bacacda

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.82ms - 1.91ms-unsure 🔍
-2% - +5%
-0.04ms - +0.09ms
preact-main1.80ms - 1.88msunsure 🔍
-5% - +2%
-0.09ms - +0.04ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local0.99ms - 1.03ms-unsure 🔍
-4% - +3%
-0.04ms - +0.03ms
preact-main0.99ms - 1.04msunsure 🔍
-3% - +4%
-0.03ms - +0.04ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local30.75ms - 31.34ms-unsure 🔍
-0% - +2%
-0.12ms - +0.51ms
preact-main30.74ms - 30.95msunsure 🔍
-2% - +0%
-0.51ms - +0.12ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.25ms - 1.25ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.25ms - 1.25msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local29.74ms - 31.05ms-unsure 🔍
-5% - +1%
-1.46ms - +0.41ms
preact-main30.26ms - 31.58msunsure 🔍
-1% - +5%
-0.41ms - +1.46ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.93ms - 2.93ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-main2.93ms - 2.94msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-

tachometer-reporter-action v2 for CI

@github-actions
Copy link

github-actions bot commented Aug 8, 2025 •
edited
Loading

Size Change: +18 B (+0.04%)

Total Size: 47.6 kB

Filename Size Change
dist/preact.js 4.7 kB +7 B (+0.15%)
dist/preact.mjs 4.72 kB +5 B (+0.11%)
dist/preact.umd.js 4.77 kB +6 B (+0.13%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 3.93 kB
compat/dist/compat.mjs 3.85 kB
compat/dist/compat.umd.js 3.98 kB
debug/dist/debug.js 3.9 kB
debug/dist/debug.mjs 3.9 kB
debug/dist/debug.umd.js 3.98 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.mjs 271 B
devtools/dist/devtools.umd.js 346 B
hooks/dist/hooks.js 1.55 kB
hooks/dist/hooks.mjs 1.58 kB
hooks/dist/hooks.umd.js 1.62 kB
jsx-runtime/dist/jsxRuntime.js 892 B
jsx-runtime/dist/jsxRuntime.mjs 861 B
jsx-runtime/dist/jsxRuntime.umd.js 966 B
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 473 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@JoviDeCroock JoviDeCroock force-pushed the ensure-memoed-components-rerender-after-error branch from 112ec70 to bacacda Compare August 8, 2025 15:19
@coveralls
Copy link

coveralls commented Aug 8, 2025 •
edited
Loading

Coverage Status

coverage: 99.539%. remained the same
when pulling d5aa9a7 on ensure-memoed-components-rerender-after-error
into aeb59e0 on main.

@JoviDeCroock JoviDeCroock merged commit 869968b into main Aug 9, 2025
13 checks passed
@JoviDeCroock JoviDeCroock deleted the ensure-memoed-components-rerender-after-error branch August 9, 2025 06:13
JoviDeCroock added a commit that referenced this pull request Aug 9, 2025
@JoviDeCroock
Ensure memoized components re-render after errors (#4880)
256f5ca
@JoviDeCroock JoviDeCroock mentioned this pull request Aug 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rschristian rschristian rschristian approved these changes

@marvinhagemeister marvinhagemeister Awaiting requested review from marvinhagemeister

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

the child component of ErrorBoundary, wrapped by memo function failed to recover from the last error

4 participants

@JoviDeCroock @coveralls @rschristian