Skip to content

Remove rerendercount #4877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoviDeCroock merged 3 commits into from
Aug 5, 2025
Merged

Remove rerendercount #4877

JoviDeCroock merged 3 commits into from
Aug 5, 2025

Conversation

@JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Aug 5, 2025

Reset rerendercounter even when we have an uncaught exception, this allows us to remove rerendercounter while also supporting fast-refresh

@github-actions
Copy link

github-actions bot commented Aug 5, 2025 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -0% - +1% (-1.10ms - +5.91ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.03ms - +0.04ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -0% - +2% (-0.32ms - +1.49ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -2% - +2% (-0.29ms - +0.27ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -3% - +1% (-1.83ms - +0.35ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -3% - +5% (-0.06ms - +0.08ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +1% (-0.26ms - +0.26ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -4% - +1% (-1.34ms - +0.46ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: faster ✔ 1% - 1% (0.16ms - 0.16ms)
    preact-local vs preact-main
  • filter-list: faster ✔ 0% - 1% (0.00ms - 0.02ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -4% - +5% (-0.35ms - +0.39ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 +0% - +0% (+0.00ms - +0.01ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +0% (-0.04ms - +0.01ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -2% - +4% (-0.02ms - +0.04ms)
    preact-local vs preact-main
  • todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: faster ✔ 0% - 1% (0.01ms - 0.02ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local962.50ms - 967.72ms-unsure 🔍
-0% - +1%
-1.10ms - +5.91ms
preact-main960.37ms - 965.04msunsure 🔍
-1% - +0%
-5.91ms - +1.10ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.03ms - 19.03ms-faster ✔
1% - 1%
0.16ms - 0.16ms
preact-main19.19ms - 19.19msslower ❌
1% - 1%
0.16ms - 0.16ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.48ms - 16.53ms-unsure 🔍
-0% - +0%
-0.03ms - +0.04ms
preact-main16.47ms - 16.53msunsure 🔍
-0% - +0%
-0.04ms - +0.03ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.53ms - 1.54ms-faster ✔
0% - 1%
0.00ms - 0.02ms
preact-main1.54ms - 1.54msslower ❌
0% - 1%
0.00ms - 0.02ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local66.60ms - 68.17ms-unsure 🔍
-0% - +2%
-0.32ms - +1.49ms
preact-main66.36ms - 67.24msunsure 🔍
-2% - +0%
-1.49ms - +0.32ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local7.61ms - 8.15ms-unsure 🔍
-4% - +5%
-0.35ms - +0.39ms
preact-main7.60ms - 8.11msunsure 🔍
-5% - +4%
-0.39ms - +0.35ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local15.86ms - 16.23ms-unsure 🔍
-2% - +2%
-0.29ms - +0.27ms
preact-main15.84ms - 16.27msunsure 🔍
-2% - +2%
-0.27ms - +0.29ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.72ms - 3.72ms-unsure 🔍
+0% - +0%
+0.00ms - +0.01ms
preact-main3.71ms - 3.72msunsure 🔍
-0% - -0%
-0.01ms - -0.00ms		-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #4975

  • Commit: bbec579

duration

VersionAvg timevs preact-localvs preact-main
preact-local61.36ms - 62.58ms-unsure 🔍
-3% - +1%
-1.83ms - +0.35ms
preact-main61.82ms - 63.61msunsure 🔍
-1% - +3%
-0.35ms - +1.83ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.08ms - 3.12ms-unsure 🔍
-1% - +0%
-0.04ms - +0.01ms
preact-main3.10ms - 3.13msunsure 🔍
-0% - +1%
-0.01ms - +0.04ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local24.90ms - 25.58ms-unsure 🔍
-2% - +1%
-0.58ms - +0.37ms
preact-main25.02ms - 25.68msunsure 🔍
-1% - +2%
-0.37ms - +0.58ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local32.95ms - 34.10ms-unsure 🔍
-0% - +5%
-0.03ms - +1.61ms
preact-main32.15ms - 33.32msunsure 🔍
-5% - +0%
-1.61ms - +0.03ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local28.90ms - 29.92ms-unsure 🔍
-2% - +3%
-0.45ms - +0.96ms
preact-main28.66ms - 29.64msunsure 🔍
-3% - +2%
-0.96ms - +0.45ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local26.29ms - 27.13ms-unsure 🔍
-3% - +1%
-0.85ms - +0.34ms
preact-main26.55ms - 27.38msunsure 🔍
-1% - +3%
-0.34ms - +0.85ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local22.39ms - 23.43ms-unsure 🔍
-2% - +4%
-0.55ms - +0.86ms
preact-main22.27ms - 23.24msunsure 🔍
-4% - +2%
-0.86ms - +0.55ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local21.08ms - 21.91ms-unsure 🔍
-4% - +1%
-0.94ms - +0.32ms
preact-main21.33ms - 22.27msunsure 🔍
-1% - +4%
-0.32ms - +0.94ms		-
text-update

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.80ms - 1.91ms-unsure 🔍
-3% - +5%
-0.06ms - +0.08ms
preact-main1.80ms - 1.90msunsure 🔍
-4% - +3%
-0.08ms - +0.06ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local0.97ms - 1.02ms-unsure 🔍
-2% - +4%
-0.02ms - +0.04ms
preact-main0.97ms - 1.01msunsure 🔍
-4% - +2%
-0.04ms - +0.02ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local33.62ms - 34.05ms-unsure 🔍
-1% - +1%
-0.26ms - +0.26ms
preact-main33.69ms - 33.99msunsure 🔍
-1% - +1%
-0.26ms - +0.26ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.24ms - 1.25ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main1.24ms - 1.24msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local32.15ms - 33.33ms-unsure 🔍
-4% - +1%
-1.34ms - +0.46ms
preact-main32.50ms - 33.86msunsure 🔍
-1% - +4%
-0.46ms - +1.34ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.92ms - 2.93ms-faster ✔
0% - 1%
0.01ms - 0.02ms
preact-main2.94ms - 2.95msslower ❌
0% - 1%
0.01ms - 0.02ms		-

tachometer-reporter-action v2 for CI

@JoviDeCroock JoviDeCroock force-pushed the remove-rerender-count branch from 219f26b to 8ee411f Compare August 5, 2025 19:57
@github-actions
Copy link

github-actions bot commented Aug 5, 2025 •
edited
Loading

Size Change: -8 B (-0.02%)

Total Size: 47.4 kB

Filename Size Change
dist/preact.js 4.67 kB -1 B (-0.02%)
dist/preact.mjs 4.69 kB -6 B (-0.13%)
dist/preact.umd.js 4.75 kB -1 B (-0.02%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 3.92 kB
compat/dist/compat.mjs 3.83 kB
compat/dist/compat.umd.js 3.97 kB
debug/dist/debug.js 3.88 kB
debug/dist/debug.mjs 3.88 kB
debug/dist/debug.umd.js 3.97 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.mjs 271 B
devtools/dist/devtools.umd.js 346 B
hooks/dist/hooks.js 1.55 kB
hooks/dist/hooks.mjs 1.58 kB
hooks/dist/hooks.umd.js 1.62 kB
jsx-runtime/dist/jsxRuntime.js 892 B
jsx-runtime/dist/jsxRuntime.mjs 861 B
jsx-runtime/dist/jsxRuntime.umd.js 966 B
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 473 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@coveralls
Copy link

coveralls commented Aug 5, 2025 •
edited
Loading

Coverage Status

coverage: 99.535%. remained the same
when pulling bbec579 on remove-rerender-count
into 943fa26 on main.

@JoviDeCroock JoviDeCroock force-pushed the remove-rerender-count branch from bfeea45 to 6d95fbf Compare August 5, 2025 20:01
@JoviDeCroock JoviDeCroock force-pushed the remove-rerender-count branch from 6d95fbf to caf4075 Compare August 5, 2025 20:03
@JoviDeCroock JoviDeCroock merged commit ac657fc into main Aug 5, 2025
13 checks passed
@JoviDeCroock JoviDeCroock deleted the remove-rerender-count branch August 5, 2025 20:19
JoviDeCroock added a commit that referenced this pull request Aug 5, 2025
@JoviDeCroock
Remove rerendercount (#4877)
e272150 
* Remove rerendercount

* Save bytes
@JoviDeCroock JoviDeCroock mentioned this pull request Aug 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rschristian rschristian rschristian approved these changes

@marvinhagemeister marvinhagemeister Awaiting requested review from marvinhagemeister

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JoviDeCroock @coveralls @rschristian