refactor: Make HTMLAttribute type declarations consistent #4876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschristian
changed the title
rschristian
force-pushed
the
types/html-attribute-types-consistency
branch
2 times, most recently
from
cda6cb2 to
9599a32
Compare
JoviDeCroock
approved these changes
Aug 8, 2025
rschristian
force-pushed
the
types/html-attribute-types-consistency
branch
from
9599a32 to
d535377
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change our
...HTMLAttributestypes were a bit inconsistent: those that relied upon discriminated unions for the ARIA roles weretype, and those that didn't wereinterface. I think this would be a bit weird and annoying for users to deal with, so as such, they've all been switched to usetype.No functional changes.