Skip to content

feat(debug): add captureOwnerStack #4875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rschristian merged 3 commits into from
Aug 6, 2025
Merged

feat(debug): add captureOwnerStack #4875

rschristian merged 3 commits into from
Aug 6, 2025

Conversation

@colinaaa
Copy link
Contributor

@colinaaa colinaaa commented Aug 5, 2025 •
edited
Loading

Export a new captureOwnerStack API from preact/debug.

captureOwnerStack is the new API added in React v19.1.0.

@github-actions
Copy link

github-actions bot commented Aug 5, 2025 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

⏳ Benchmarks are currently running. Results below are out of date.

duration

  • create10k: unsure 🔍 -0% - +0% (-4.16ms - +3.53ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.04ms - +0.04ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +2% (-1.11ms - +1.57ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -1% - +1% (-0.15ms - +0.12ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -2% - +1% (-1.12ms - +0.54ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -1% - +6% (-0.01ms - +0.11ms)
    preact-local vs preact-main
  • todo: faster ✔ 0% - 1% (0.04ms - 0.44ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -4% - +1% (-1.34ms - +0.34ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: faster ✔ 1% - 1% (0.16ms - 0.16ms)
    preact-local vs preact-main
  • filter-list: faster ✔ 0% - 1% (0.01ms - 0.01ms)
    preact-local vs preact-main
  • hydrate1k: faster ✔ 1% - 12% (0.03ms - 0.76ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 +0% - +0% (+0.00ms - +0.01ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +0% (-0.03ms - +0.01ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -3% - +1% (-0.03ms - +0.01ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +1% (-0.01ms - +0.01ms)
    preact-local vs preact-main
  • update10th1k: faster ✔ 0% - 1% (0.01ms - 0.02ms)
    preact-local vs preact-main

Results

⏳ Benchmarks are currently running. Results below are out of date.
create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local949.69ms - 954.83ms-unsure 🔍
-0% - +0%
-4.16ms - +3.53ms
preact-main949.71ms - 955.43msunsure 🔍
-0% - +0%
-3.53ms - +4.16ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.03ms - 19.03ms-faster ✔
1% - 1%
0.16ms - 0.16ms
preact-main19.19ms - 19.19msslower ❌
1% - 1%
0.16ms - 0.16ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.49ms - 16.52ms-unsure 🔍
-0% - +0%
-0.04ms - +0.04ms
preact-main16.48ms - 16.54msunsure 🔍
-0% - +0%
-0.04ms - +0.04ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.53ms - 1.53ms-faster ✔
0% - 1%
0.01ms - 0.01ms
preact-main1.54ms - 1.54msslower ❌
0% - 1%
0.01ms - 0.01ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local68.48ms - 70.47ms-unsure 🔍
-2% - +2%
-1.11ms - +1.57ms
preact-main68.35ms - 70.15msunsure 🔍
-2% - +2%
-1.57ms - +1.11ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local5.73ms - 6.20ms-faster ✔
1% - 12%
0.03ms - 0.76ms
preact-main6.08ms - 6.64msslower ❌
0% - 13%
0.03ms - 0.76ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.36ms - 16.57ms-unsure 🔍
-1% - +1%
-0.15ms - +0.12ms
preact-main16.39ms - 16.56msunsure 🔍
-1% - +1%
-0.12ms - +0.15ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.71ms - 3.72ms-unsure 🔍
+0% - +0%
+0.00ms - +0.01ms
preact-main3.71ms - 3.71msunsure 🔍
-0% - -0%
-0.01ms - -0.00ms		-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #4994

  • Commit: 7e479ea

duration

VersionAvg timevs preact-localvs preact-main
preact-local60.17ms - 61.24ms-unsure 🔍
-2% - +1%
-1.12ms - +0.54ms
preact-main60.36ms - 61.62msunsure 🔍
-1% - +2%
-0.54ms - +1.12ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.10ms - 3.13ms-unsure 🔍
-1% - +0%
-0.03ms - +0.01ms
preact-main3.11ms - 3.14msunsure 🔍
-0% - +1%
-0.01ms - +0.03ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local25.62ms - 26.48ms-unsure 🔍
-0% - +4%
-0.08ms - +1.03ms
preact-main25.22ms - 25.92msunsure 🔍
-4% - +0%
-1.03ms - +0.08ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local32.78ms - 33.91ms-unsure 🔍
-1% - +4%
-0.19ms - +1.41ms
preact-main32.17ms - 33.30msunsure 🔍
-4% - +1%
-1.41ms - +0.19ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local28.16ms - 29.07ms-unsure 🔍
-4% - +1%
-1.08ms - +0.21ms
preact-main28.58ms - 29.51msunsure 🔍
-1% - +4%
-0.21ms - +1.08ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local25.99ms - 26.88ms-unsure 🔍
-3% - +2%
-0.72ms - +0.47ms
preact-main26.16ms - 26.96msunsure 🔍
-2% - +3%
-0.47ms - +0.72ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local21.79ms - 22.90ms-unsure 🔍
-4% - +2%
-1.02ms - +0.56ms
preact-main22.02ms - 23.13msunsure 🔍
-3% - +5%
-0.56ms - +1.02ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local20.66ms - 21.46ms-unsure 🔍
-3% - +3%
-0.57ms - +0.61ms
preact-main20.61ms - 21.47msunsure 🔍
-3% - +3%
-0.61ms - +0.57ms		-
text-update
  • Browser: chrome-headless
  • Sample size: 240
  • Built by: CI #4994

  • Commit: 7e479ea

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.81ms - 1.91ms-unsure 🔍
-1% - +6%
-0.01ms - +0.11ms
preact-main1.78ms - 1.85msunsure 🔍
-6% - +1%
-0.11ms - +0.01ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local0.98ms - 1.01ms-unsure 🔍
-3% - +1%
-0.03ms - +0.01ms
preact-main0.99ms - 1.02msunsure 🔍
-1% - +3%
-0.01ms - +0.03ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local31.93ms - 32.12ms-faster ✔
0% - 1%
0.04ms - 0.44ms
preact-main32.09ms - 32.44msslower ❌
0% - 1%
0.04ms - 0.44ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.25ms - 1.25ms-unsure 🔍
-1% - +1%
-0.01ms - +0.01ms
preact-main1.24ms - 1.25msunsure 🔍
-1% - +1%
-0.01ms - +0.01ms		-
update10th1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #4994

  • Commit: 7e479ea

duration

VersionAvg timevs preact-localvs preact-main
preact-local28.84ms - 29.94ms-unsure 🔍
-4% - +1%
-1.34ms - +0.34ms
preact-main29.25ms - 30.52msunsure 🔍
-1% - +5%
-0.34ms - +1.34ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.93ms - 2.93ms-faster ✔
0% - 1%
0.01ms - 0.02ms
preact-main2.94ms - 2.95msslower ❌
0% - 1%
0.01ms - 0.02ms		-

tachometer-reporter-action v2 for CI

@coveralls
Copy link

coveralls commented Aug 5, 2025 •
edited
Loading

Coverage Status

coverage: 99.537% (+0.002%) from 99.535%
when pulling 536fe5f on colinaaa:colin/0805/captureOwnerStack
into 2c47637 on preactjs:main.

rschristian
rschristian reviewed Aug 5, 2025
View reviewed changes
@colinaaa colinaaa changed the title fix(debug)!: add captureOwnerStack feat(debug): add captureOwnerStack Aug 6, 2025
@rschristian rschristian merged commit f3430e0 into preactjs:main Aug 6, 2025
12 checks passed
@JoviDeCroock JoviDeCroock mentioned this pull request Aug 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rschristian rschristian rschristian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@colinaaa @coveralls @rschristian