Add flags for component type #4867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Tachometer Benchmark ResultsSummary⏳ Benchmarks are currently running. Results below are out of date. duration
usedJSHeapSize
Results⏳ Benchmarks are currently running. Results below are out of date. create10kduration
usedJSHeapSize
filter-listduration
usedJSHeapSize
hydrate1kduration
usedJSHeapSize
many-updatesduration
usedJSHeapSize
replace1kduration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-updateduration
usedJSHeapSize
tododuration
usedJSHeapSize
update10th1kduration
usedJSHeapSize
|
JoviDeCroock
force-pushed
the
test-flags-additions
branch
from
5e6c82c to
1444798
Compare
|
Size Change: +87 B (+0.18%) Total Size: 47.4 kB
ℹ️ View Unchanged
|
JoviDeCroock
force-pushed
the
test-flags-additions
branch
2 times, most recently
from
cdeb3bf to
2a93d67
Compare
JoviDeCroock
force-pushed
the
test-flags-additions
branch
2 times, most recently
from
de8480e to
0065bde
Compare
JoviDeCroock
commented
Jul 31, 2025
JoviDeCroock
force-pushed
the
test-flags-additions
branch
2 times, most recently
from
0da0f21 to
7a1c6af
Compare
JoviDeCroock
force-pushed
the
test-flags-additions
branch
from
36e0777 to
2cb17d2
Compare
JoviDeCroock
force-pushed
the
test-flags-additions
branch
from
efe226a to
005ae3d
Compare
JoviDeCroock
commented
Aug 5, 2025
| _processingException?: Component<any, any> | null; | ||
| // Always read, set only when handling error. This is used to indicate at diffTime to set _processingException | ||
| _pendingError?: Component<any, any> | null; | ||
| _bits: number; |
Member
Author
There was a problem hiding this comment.
Named it bits because the _flags mangle would conflict
JoviDeCroock
force-pushed
the
test-flags-additions
branch
from
005ae3d to
1ab2f62
Compare
rschristian
approved these changes
Aug 5, 2025
JoviDeCroock
added a commit
that referenced
this pull request
Aug 5, 2025
* Add flags for component type * Add bit flags for pending error * Migrate _force flag * Add _dirty flag * Save bytes by moving back to typeof
JoviDeCroock
added a commit
that referenced
this pull request
Aug 5, 2025
* Add flags for component type * Add bit flags for pending error * Migrate _force flag * Add _dirty flag * Save bytes by moving back to typeof
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of want to add more things onto flags while maintaining backwards compatability, type will always be present so this one does not break anything special. We could consider
_dirtyand others as well.Follow ups