Skip to content

Bump testing/transpilation/formatting deps #4858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoviDeCroock merged 3 commits into from
Jul 28, 2025
Merged

Bump testing/transpilation/formatting deps #4858

JoviDeCroock merged 3 commits into from
Jul 28, 2025

Conversation

@JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Jul 28, 2025

This bumps vitest, babel, ...

We also have a new major of biome which slightly changes formatting as well as shows that we have a bug in the node packages package.json as we enforce commonjs while it needs to be module as we use .js files for export/import.

@JoviDeCroock JoviDeCroock changed the title Bump deps 2 Bump testing/transpilation/formatting deps Jul 28, 2025
@JoviDeCroock JoviDeCroock requested a review from rschristian July 28, 2025 08:25
@github-actions
Copy link

github-actions bot commented Jul 28, 2025 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +1% (-10.28ms - +14.63ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.03ms - +0.08ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +1% (-1.96ms - +0.37ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.03ms - +0.02ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -2% - +1% (-1.06ms - +0.63ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -7% - +8% (-0.15ms - +0.16ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +2% (-0.12ms - +0.60ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -2% - +4% (-0.43ms - +1.21ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -7% - +6% (-0.43ms - +0.37ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +1% (-0.02ms - +0.02ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -2% - +1% (-0.02ms - +0.01ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local984.25ms - 1004.09ms-unsure 🔍
-1% - +1%
-10.28ms - +14.63ms
preact-main984.46ms - 999.52msunsure 🔍
-1% - +1%
-14.63ms - +10.28ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.19ms - 19.19ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main19.19ms - 19.19msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.48ms - 16.57ms-unsure 🔍
-0% - +0%
-0.03ms - +0.08ms
preact-main16.47ms - 16.53msunsure 🔍
-0% - +0%
-0.08ms - +0.03ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.54ms - 1.54ms-unsure 🔍
-1% - +0%
-0.01ms - +0.00ms
preact-main1.54ms - 1.55msunsure 🔍
-0% - +1%
-0.00ms - +0.01ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local67.30ms - 68.92ms-unsure 🔍
-3% - +1%
-1.96ms - +0.37ms
preact-main68.07ms - 69.74msunsure 🔍
-1% - +3%
-0.37ms - +1.96ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local5.93ms - 6.47ms-unsure 🔍
-7% - +6%
-0.43ms - +0.37ms
preact-main5.94ms - 6.52msunsure 🔍
-6% - +7%
-0.37ms - +0.43ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.53ms - 16.57ms-unsure 🔍
-0% - +0%
-0.03ms - +0.02ms
preact-main16.54ms - 16.58msunsure 🔍
-0% - +0%
-0.02ms - +0.03ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.71ms - 3.71ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.71ms - 3.71msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #4930

  • Commit: 6cf36f6

duration

VersionAvg timevs preact-localvs preact-main
preact-local62.13ms - 63.36ms-unsure 🔍
-2% - +1%
-1.06ms - +0.63ms
preact-main62.39ms - 63.53msunsure 🔍
-1% - +2%
-0.63ms - +1.06ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.10ms - 3.13ms-unsure 🔍
-1% - +1%
-0.02ms - +0.02ms
preact-main3.11ms - 3.14msunsure 🔍
-1% - +1%
-0.02ms - +0.02ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local25.12ms - 25.88ms-unsure 🔍
-2% - +2%
-0.48ms - +0.61ms
preact-main25.04ms - 25.82msunsure 🔍
-2% - +2%
-0.61ms - +0.48ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local33.01ms - 34.00ms-unsure 🔍
-1% - +3%
-0.39ms - +1.09ms
preact-main32.60ms - 33.70msunsure 🔍
-3% - +1%
-1.09ms - +0.39ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local29.54ms - 30.57ms-unsure 🔍
-1% - +4%
-0.29ms - +1.12ms
preact-main29.15ms - 30.13msunsure 🔍
-4% - +1%
-1.12ms - +0.29ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local27.05ms - 27.85ms-unsure 🔍
-1% - +3%
-0.37ms - +0.86ms
preact-main26.74ms - 27.68msunsure 🔍
-3% - +1%
-0.86ms - +0.37ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local22.62ms - 23.74ms-unsure 🔍
-2% - +5%
-0.51ms - +1.04ms
preact-main22.37ms - 23.45msunsure 🔍
-4% - +2%
-1.04ms - +0.51ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local20.98ms - 21.75ms-unsure 🔍
-3% - +2%
-0.58ms - +0.49ms
preact-main21.05ms - 21.78msunsure 🔍
-2% - +3%
-0.49ms - +0.58ms		-
text-update
  • Browser: chrome-headless
  • Sample size: 220
  • Built by: CI #4930

  • Commit: 6cf36f6

duration

VersionAvg timevs preact-localvs preact-main
preact-local2.01ms - 2.23ms-unsure 🔍
-7% - +8%
-0.15ms - +0.16ms
preact-main2.00ms - 2.23msunsure 🔍
-8% - +7%
-0.16ms - +0.15ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local0.97ms - 0.99ms-unsure 🔍
-2% - +1%
-0.02ms - +0.01ms
preact-main0.97ms - 0.99msunsure 🔍
-1% - +2%
-0.01ms - +0.02ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local32.57ms - 33.24ms-unsure 🔍
-0% - +2%
-0.12ms - +0.60ms
preact-main32.53ms - 32.80msunsure 🔍
-2% - +0%
-0.60ms - +0.12ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.24ms - 1.24ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.24ms - 1.24msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local28.31ms - 29.57ms-unsure 🔍
-2% - +4%
-0.43ms - +1.21ms
preact-main28.03ms - 29.08msunsure 🔍
-4% - +1%
-1.21ms - +0.43ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.94ms - 2.95ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main2.94ms - 2.95msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-

tachometer-reporter-action v2 for CI

@github-actions
Copy link

github-actions bot commented Jul 28, 2025 •
edited
Loading

Size Change: -8 B (-0.02%)

Total Size: 47.3 kB

Filename Size Change
debug/dist/debug.mjs 3.88 kB -6 B (-0.15%)
debug/dist/debug.umd.js 3.97 kB -2 B (-0.05%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 3.91 kB
compat/dist/compat.mjs 3.82 kB
compat/dist/compat.umd.js 3.96 kB
debug/dist/debug.js 3.88 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.mjs 271 B
devtools/dist/devtools.umd.js 346 B
dist/preact.js 4.65 kB
dist/preact.mjs 4.66 kB
dist/preact.umd.js 4.72 kB
hooks/dist/hooks.js 1.55 kB
hooks/dist/hooks.mjs 1.58 kB
hooks/dist/hooks.umd.js 1.62 kB
jsx-runtime/dist/jsxRuntime.js 892 B
jsx-runtime/dist/jsxRuntime.mjs 861 B
jsx-runtime/dist/jsxRuntime.umd.js 966 B
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 473 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

JoviDeCroock
JoviDeCroock commented Jul 28, 2025
View reviewed changes
package.json
"terser": "5.16.0",
"typescript": "5.1.6",
"undici": "^4.12.0",
"vite": "^6.2.0",
Copy link
Member Author

@JoviDeCroock JoviDeCroock Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vite has a 7.0.0 but it looks like it currently crashes due to crypto.hash not being a function locally. Volta does not seem to apply the node v20.19 for me 😅 going to leave the bump in the middle for now

rschristian
rschristian approved these changes Jul 28, 2025
View reviewed changes
@coveralls
Copy link

coveralls commented Jul 28, 2025 •
edited
Loading

Coverage Status

coverage: 99.534% (+0.001%) from 99.533%
when pulling 6cf36f6 on bump-deps-2
into c3151f5 on main.

@JoviDeCroock JoviDeCroock merged commit ffe1529 into main Jul 28, 2025
13 checks passed
@JoviDeCroock JoviDeCroock deleted the bump-deps-2 branch July 28, 2025 08:38
@JoviDeCroock JoviDeCroock mentioned this pull request Aug 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rschristian rschristian rschristian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JoviDeCroock @coveralls @rschristian