Skip to content

Ensure we properly re-render bailing errored children #4857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoviDeCroock merged 3 commits into from
Jul 28, 2025
Merged

Ensure we properly re-render bailing errored children #4857

JoviDeCroock merged 3 commits into from
Jul 28, 2025

Conversation

@JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Jul 28, 2025 •
edited
Loading

Frontport of #4856 (description is there)

Found the issue in #4854

@github-actions
Copy link

github-actions bot commented Jul 28, 2025 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -0% - +0% (-2.95ms - +3.93ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +3% (-0.11ms - +0.47ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +0% (-1.82ms - +0.23ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.04ms - +0.05ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +1% (-0.78ms - +0.74ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -3% - +5% (-0.07ms - +0.09ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -3% - +0% (-0.85ms - +0.16ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -5% - +3% (-1.42ms - +0.86ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +12% (-0.07ms - +0.71ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +1% (-0.02ms - +0.03ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -2% - +3% (-0.02ms - +0.03ms)
    preact-local vs preact-main
  • todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local957.13ms - 961.67ms-unsure 🔍
-0% - +0%
-2.95ms - +3.93ms
preact-main956.32ms - 961.49msunsure 🔍
-0% - +0%
-3.93ms - +2.95ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.19ms - 19.19ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main19.18ms - 19.19msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.44ms - 17.00ms-unsure 🔍
-1% - +3%
-0.11ms - +0.47ms
preact-main16.47ms - 16.61msunsure 🔍
-3% - +1%
-0.47ms - +0.11ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.54ms - 1.55ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main1.54ms - 1.54msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local67.58ms - 69.03ms-unsure 🔍
-3% - +0%
-1.82ms - +0.23ms
preact-main68.38ms - 69.83msunsure 🔍
-0% - +3%
-0.23ms - +1.82ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local5.89ms - 6.45ms-unsure 🔍
-1% - +12%
-0.07ms - +0.71ms
preact-main5.58ms - 6.12msunsure 🔍
-11% - +1%
-0.71ms - +0.07ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.53ms - 16.60ms-unsure 🔍
-0% - +0%
-0.04ms - +0.05ms
preact-main16.53ms - 16.59msunsure 🔍
-0% - +0%
-0.05ms - +0.04ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.71ms - 3.71ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.71ms - 3.71msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #4927

  • Commit: 86a419e

duration

VersionAvg timevs preact-localvs preact-main
preact-local61.64ms - 62.76ms-unsure 🔍
-1% - +1%
-0.78ms - +0.74ms
preact-main61.70ms - 62.74msunsure 🔍
-1% - +1%
-0.74ms - +0.78ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.10ms - 3.13ms-unsure 🔍
-1% - +1%
-0.02ms - +0.03ms
preact-main3.09ms - 3.13msunsure 🔍
-1% - +1%
-0.03ms - +0.02ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local25.07ms - 25.75ms-unsure 🔍
-1% - +3%
-0.28ms - +0.65ms
preact-main24.91ms - 25.54msunsure 🔍
-3% - +1%
-0.65ms - +0.28ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local32.76ms - 33.83ms-unsure 🔍
-4% - +1%
-1.26ms - +0.28ms
preact-main33.23ms - 34.33msunsure 🔍
-1% - +4%
-0.28ms - +1.26ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local29.31ms - 30.28ms-unsure 🔍
-0% - +5%
-0.01ms - +1.32ms
preact-main28.68ms - 29.60msunsure 🔍
-4% - +0%
-1.32ms - +0.01ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local27.12ms - 27.90ms-unsure 🔍
-2% - +3%
-0.45ms - +0.75ms
preact-main26.90ms - 27.81msunsure 🔍
-3% - +2%
-0.75ms - +0.45ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local22.81ms - 23.97ms-unsure 🔍
-2% - +5%
-0.39ms - +1.19ms
preact-main22.46ms - 23.53msunsure 🔍
-5% - +2%
-1.19ms - +0.39ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local21.06ms - 21.80ms-unsure 🔍
-2% - +2%
-0.53ms - +0.53ms
preact-main21.05ms - 21.81msunsure 🔍
-2% - +2%
-0.53ms - +0.53ms		-
text-update
  • Browser: chrome-headless
  • Sample size: 240
  • Built by: CI #4927

  • Commit: 86a419e

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.88ms - 2.01ms-unsure 🔍
-3% - +5%
-0.07ms - +0.09ms
preact-main1.89ms - 1.98msunsure 🔍
-5% - +3%
-0.09ms - +0.07ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local0.98ms - 1.01ms-unsure 🔍
-2% - +3%
-0.02ms - +0.03ms
preact-main0.98ms - 1.01msunsure 🔍
-3% - +2%
-0.03ms - +0.02ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local32.76ms - 33.20ms-unsure 🔍
-3% - +0%
-0.85ms - +0.16ms
preact-main32.87ms - 33.77msunsure 🔍
-0% - +3%
-0.16ms - +0.85ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.24ms - 1.24ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main1.24ms - 1.24msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local29.28ms - 30.84ms-unsure 🔍
-5% - +3%
-1.42ms - +0.86ms
preact-main29.52ms - 31.18msunsure 🔍
-3% - +5%
-0.86ms - +1.42ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.94ms - 2.95ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-main2.94ms - 2.95msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-

tachometer-reporter-action v2 for CI

JoviDeCroock
JoviDeCroock commented Jul 28, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jul 28, 2025 •
edited
Loading

Size Change: +97 B (+0.21%)

Total Size: 47.3 kB

Filename Size Change
dist/preact.js 4.65 kB +30 B (+0.65%)
dist/preact.mjs 4.66 kB +34 B (+0.73%)
dist/preact.umd.js 4.72 kB +33 B (+0.7%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 3.91 kB
compat/dist/compat.mjs 3.82 kB
compat/dist/compat.umd.js 3.96 kB
debug/dist/debug.js 3.88 kB
debug/dist/debug.mjs 3.89 kB
debug/dist/debug.umd.js 3.97 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.mjs 271 B
devtools/dist/devtools.umd.js 346 B
hooks/dist/hooks.js 1.55 kB
hooks/dist/hooks.mjs 1.58 kB
hooks/dist/hooks.umd.js 1.62 kB
jsx-runtime/dist/jsxRuntime.js 892 B
jsx-runtime/dist/jsxRuntime.mjs 861 B
jsx-runtime/dist/jsxRuntime.umd.js 966 B
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 473 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@coveralls
Copy link

coveralls commented Jul 28, 2025 •
edited
Loading

Coverage Status

coverage: 99.533%. remained the same
when pulling 86a419e on fix-suspense-error-bail
into 6734ff2 on main.

marvinhagemeister
marvinhagemeister approved these changes Jul 28, 2025
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoviDeCroock JoviDeCroock merged commit c3151f5 into main Jul 28, 2025
13 checks passed
@JoviDeCroock JoviDeCroock deleted the fix-suspense-error-bail branch July 28, 2025 08:14
@JoviDeCroock JoviDeCroock mentioned this pull request Aug 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@rschristian rschristian rschristian approved these changes

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JoviDeCroock @coveralls @marvinhagemeister @rschristian