Skip to content

Support alternative contentDocument #4851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoviDeCroock merged 4 commits into from
Jul 26, 2025
Merged

Support alternative contentDocument #4851

JoviDeCroock merged 4 commits into from
Jul 26, 2025

Conversation

@JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Jul 24, 2025 •
edited
Loading

Supersedes #4501
Supersedes #3042
Closes #4500

@github-actions
Copy link

github-actions bot commented Jul 24, 2025 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -0% - +0% (-3.69ms - +3.50ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.02ms - +0.06ms)
    preact-local vs preact-main
  • hydrate1k: faster ✔ 0% - 4% (0.25ms - 2.52ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -2% - +2% (-0.41ms - +0.30ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -2% - +1% (-1.00ms - +0.90ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -2% - +4% (-0.03ms - +0.08ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +0% (-0.30ms - +0.07ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -3% - +4% (-1.00ms - +1.23ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +1% (-0.01ms - +0.01ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -5% - +8% (-0.28ms - +0.49ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +1% (-0.02ms - +0.02ms)
    preact-local vs preact-main
  • text-update: faster ✔ 3% - 8% (0.03ms - 0.08ms)
    preact-local vs preact-main
  • todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local959.61ms - 963.91ms-unsure 🔍
-0% - +0%
-3.69ms - +3.50ms
preact-main958.98ms - 964.74msunsure 🔍
-0% - +0%
-3.50ms - +3.69ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.19ms - 19.19ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main19.18ms - 19.18msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.48ms - 16.54ms-unsure 🔍
-0% - +0%
-0.02ms - +0.06ms
preact-main16.47ms - 16.51msunsure 🔍
-0% - +0%
-0.06ms - +0.02ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.54ms - 1.55ms-unsure 🔍
-1% - +1%
-0.01ms - +0.01ms
preact-main1.53ms - 1.55msunsure 🔍
-1% - +1%
-0.01ms - +0.01ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local65.90ms - 67.39ms-faster ✔
0% - 4%
0.25ms - 2.52ms
preact-main67.17ms - 68.89msslower ❌
0% - 4%
0.25ms - 2.52ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local5.72ms - 6.32ms-unsure 🔍
-5% - +8%
-0.28ms - +0.49ms
preact-main5.67ms - 6.16msunsure 🔍
-8% - +5%
-0.49ms - +0.28ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.17ms - 16.71ms-unsure 🔍
-2% - +2%
-0.41ms - +0.30ms
preact-main16.26ms - 16.73msunsure 🔍
-2% - +3%
-0.30ms - +0.41ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.71ms - 3.72ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main3.71ms - 3.72msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #4909

  • Commit: af1bd0f

duration

VersionAvg timevs preact-localvs preact-main
preact-local62.24ms - 63.62ms-unsure 🔍
-2% - +1%
-1.00ms - +0.90ms
preact-main62.32ms - 63.64msunsure 🔍
-1% - +2%
-0.90ms - +1.00ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.11ms - 3.14ms-unsure 🔍
-1% - +1%
-0.02ms - +0.02ms
preact-main3.11ms - 3.14msunsure 🔍
-1% - +1%
-0.02ms - +0.02ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local24.80ms - 25.46ms-faster ✔
2% - 6%
0.42ms - 1.50ms
preact-main25.66ms - 26.51msslower ❌
2% - 6%
0.42ms - 1.50ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local32.33ms - 33.48ms-unsure 🔍
-4% - +1%
-1.41ms - +0.25ms
preact-main32.89ms - 34.08msunsure 🔍
-1% - +4%
-0.25ms - +1.41ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local29.18ms - 30.07ms-unsure 🔍
-3% - +2%
-0.78ms - +0.53ms
preact-main29.27ms - 30.23msunsure 🔍
-2% - +3%
-0.53ms - +0.78ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local26.72ms - 27.59ms-unsure 🔍
-1% - +3%
-0.39ms - +0.84ms
preact-main26.49ms - 27.37msunsure 🔍
-3% - +1%
-0.84ms - +0.39ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local22.58ms - 23.80ms-unsure 🔍
-4% - +3%
-1.01ms - +0.65ms
preact-main22.81ms - 23.93msunsure 🔍
-3% - +4%
-0.65ms - +1.01ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local20.70ms - 21.41ms-unsure 🔍
-5% - +1%
-1.00ms - +0.12ms
preact-main21.06ms - 21.93msunsure 🔍
-1% - +5%
-0.12ms - +1.00ms		-
text-update
  • Browser: chrome-headless
  • Sample size: 240
  • Built by: CI #4909

  • Commit: af1bd0f

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.82ms - 1.91ms-unsure 🔍
-2% - +4%
-0.03ms - +0.08ms
preact-main1.82ms - 1.88msunsure 🔍
-4% - +2%
-0.08ms - +0.03ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local0.97ms - 0.99ms-faster ✔
3% - 8%
0.03ms - 0.08ms
preact-main1.01ms - 1.06msslower ❌
3% - 9%
0.03ms - 0.08ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local32.61ms - 32.87ms-unsure 🔍
-1% - +0%
-0.30ms - +0.07ms
preact-main32.72ms - 32.99msunsure 🔍
-0% - +1%
-0.07ms - +0.30ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.24ms - 1.24ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main1.24ms - 1.24msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local28.08ms - 29.68ms-unsure 🔍
-3% - +4%
-1.00ms - +1.23ms
preact-main27.98ms - 29.54msunsure 🔍
-4% - +3%
-1.23ms - +1.00ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.94ms - 2.95ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-main2.94ms - 2.94msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms		-

tachometer-reporter-action v2 for CI

@github-actions
Copy link

github-actions bot commented Jul 24, 2025 •
edited
Loading

Size Change: +94 B (+0.2%)

Total Size: 47.3 kB

Filename Size Change
compat/dist/compat.js 3.94 kB +11 B (+0.28%)
compat/dist/compat.mjs 3.85 kB +13 B (+0.34%)
compat/dist/compat.umd.js 3.99 kB +13 B (+0.33%)
dist/preact.js 4.62 kB +18 B (+0.39%)
dist/preact.mjs 4.63 kB +20 B (+0.43%)
dist/preact.umd.js 4.69 kB +19 B (+0.41%)
ℹ️ View Unchanged
Filename Size
debug/dist/debug.js 3.88 kB
debug/dist/debug.mjs 3.89 kB
debug/dist/debug.umd.js 3.97 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.mjs 271 B
devtools/dist/devtools.umd.js 346 B
hooks/dist/hooks.js 1.55 kB
hooks/dist/hooks.mjs 1.58 kB
hooks/dist/hooks.umd.js 1.62 kB
jsx-runtime/dist/jsxRuntime.js 892 B
jsx-runtime/dist/jsxRuntime.mjs 861 B
jsx-runtime/dist/jsxRuntime.umd.js 966 B
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 473 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@coveralls
Copy link

coveralls commented Jul 24, 2025 •
edited
Loading

Coverage Status

coverage: 99.537%. remained the same
when pulling af1bd0f on support-alternate-content-doc
into 2712cb5 on main.

@JoviDeCroock JoviDeCroock force-pushed the support-alternate-content-doc branch from c41a9d4 to a5bfac8 Compare July 24, 2025 19:30
marvinhagemeister
marvinhagemeister approved these changes Jul 24, 2025
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoviDeCroock JoviDeCroock merged commit 13a5ce7 into main Jul 26, 2025
13 checks passed
@JoviDeCroock JoviDeCroock deleted the support-alternate-content-doc branch July 26, 2025 09:49
This was referenced Jul 26, 2025
Closed
Closed
@JoviDeCroock JoviDeCroock mentioned this pull request Aug 19, 2025
Merged
@rschristian rschristian mentioned this pull request Sep 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@rschristian rschristian rschristian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add an option to inject the document for a render()

5 participants

@JoviDeCroock @coveralls @marvinhagemeister @rschristian