fix(debug): fix memory leak in VNode owner tracking #4850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Tachometer Benchmark ResultsSummaryA summary of the benchmark results will show here once they finish. ResultsThe full results of your benchmarks will show here once they finish. |
|
Size Change: +11 B (+0.02%) Total Size: 47.2 kB
ℹ️ View Unchanged
|
rschristian
approved these changes
Jul 24, 2025
Member
rschristian
left a comment
rschristian
left a comment
There was a problem hiding this comment.
The linked signals issue can be reproduced in prod builds so unfortunately this won't be the cause. Good find anyhow though!
JoviDeCroock
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes preactjs/signals#726. The issue was that
preact/debugcalculates and assigns an_ownerproperty (minified as__o) on every VNode that refers to its owning component, creating a cycle. Switching from a property a WeakMap is better for performance anyway, as it moves the cost intogetComponentStack()which is a debugging helper that is only called in response to errors.