Skip to content

fix: signal attribute values not working with precompile transform #4799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marvinhagemeister merged 1 commit into from
Jun 11, 2025
Merged

fix: signal attribute values not working with precompile transform #4799

marvinhagemeister merged 1 commit into from
Jun 11, 2025

Conversation

@marvinhagemeister
Copy link
Member

@marvinhagemeister marvinhagemeister commented Jun 11, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 11, 2025 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -0% - +0% (-2.92ms - +2.72ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.01ms - +0.06ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +1% (-2.38ms - +1.00ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +1% (-0.07ms - +0.19ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -3% - +1% (-1.74ms - +0.50ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -1% - +6% (-0.02ms - +0.13ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +1% (-0.36ms - +0.25ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -3% - +4% (-0.85ms - +1.25ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -7% - +5% (-0.42ms - +0.30ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -2% - +2% (-0.02ms - +0.02ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local973.74ms - 978.13ms-unsure 🔍
-0% - +0%
-2.92ms - +2.72ms
preact-main974.26ms - 977.80msunsure 🔍
-0% - +0%
-2.72ms - +2.92ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.19ms - 19.19ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main19.19ms - 19.19msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.52ms - 16.57ms-unsure 🔍
-0% - +0%
-0.01ms - +0.06ms
preact-main16.50ms - 16.54msunsure 🔍
-0% - +0%
-0.06ms - +0.01ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.54ms - 1.55ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.54ms - 1.55msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local76.64ms - 79.16ms-unsure 🔍
-3% - +1%
-2.38ms - +1.00ms
preact-main77.46ms - 79.72msunsure 🔍
-1% - +3%
-1.00ms - +2.38ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local5.65ms - 6.10ms-unsure 🔍
-7% - +5%
-0.42ms - +0.30ms
preact-main5.66ms - 6.22msunsure 🔍
-5% - +7%
-0.30ms - +0.42ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.48ms - 16.73ms-unsure 🔍
-0% - +1%
-0.07ms - +0.19ms
preact-main16.50ms - 16.58msunsure 🔍
-1% - +0%
-0.19ms - +0.07ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.77ms - 3.78ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.77ms - 3.78msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #4785

  • Commit: a62ee4d

duration

VersionAvg timevs preact-localvs preact-main
preact-local62.68ms - 64.00ms-unsure 🔍
-3% - +1%
-1.74ms - +0.50ms
preact-main63.05ms - 64.87msunsure 🔍
-1% - +3%
-0.50ms - +1.74ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.99ms - 3.00ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main2.99ms - 2.99msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local25.35ms - 26.10ms-unsure 🔍
-4% - +0%
-1.04ms - +0.03ms
preact-main25.85ms - 26.62msunsure 🔍
-0% - +4%
-0.03ms - +1.04ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local32.80ms - 34.16ms-unsure 🔍
-3% - +3%
-1.00ms - +0.91ms
preact-main32.86ms - 34.19msunsure 🔍
-3% - +3%
-0.91ms - +1.00ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local28.71ms - 29.70ms-unsure 🔍
-2% - +3%
-0.59ms - +0.74ms
preact-main28.68ms - 29.57msunsure 🔍
-3% - +2%
-0.74ms - +0.59ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local26.28ms - 27.26ms-unsure 🔍
-2% - +3%
-0.60ms - +0.72ms
preact-main26.27ms - 27.15msunsure 🔍
-3% - +2%
-0.72ms - +0.60ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local22.83ms - 23.89ms-unsure 🔍
-5% - +2%
-1.19ms - +0.39ms
preact-main23.18ms - 24.35msunsure 🔍
-2% - +5%
-0.39ms - +1.19ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local20.99ms - 21.76ms-unsure 🔍
-4% - +2%
-0.76ms - +0.45ms
preact-main21.06ms - 21.99msunsure 🔍
-2% - +4%
-0.45ms - +0.76ms		-
text-update
  • Browser: chrome-headless
  • Sample size: 240
  • Built by: CI #4785

  • Commit: a62ee4d

duration

VersionAvg timevs preact-localvs preact-main
preact-local2.08ms - 2.19ms-unsure 🔍
-1% - +6%
-0.02ms - +0.13ms
preact-main2.03ms - 2.13msunsure 🔍
-6% - +1%
-0.13ms - +0.02ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local0.97ms - 1.00ms-unsure 🔍
-2% - +2%
-0.02ms - +0.02ms
preact-main0.97ms - 1.00msunsure 🔍
-2% - +2%
-0.02ms - +0.02ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local33.32ms - 33.67ms-unsure 🔍
-1% - +1%
-0.36ms - +0.25ms
preact-main33.30ms - 33.80msunsure 🔍
-1% - +1%
-0.25ms - +0.36ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.24ms - 1.25ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.24ms - 1.25msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local30.77ms - 32.32ms-unsure 🔍
-3% - +4%
-0.85ms - +1.25ms
preact-main30.63ms - 32.05msunsure 🔍
-4% - +3%
-1.25ms - +0.85ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.12ms - 3.13ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main3.12ms - 3.12msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-

tachometer-reporter-action v2 for CI

@github-actions
Copy link

github-actions bot commented Jun 11, 2025

Size Change: +93 B (+0.2%)

Total Size: 46.7 kB

Filename Size Change
jsx-runtime/dist/jsxRuntime.js 892 B +30 B (+3.48%)
jsx-runtime/dist/jsxRuntime.mjs 861 B +31 B (+3.73%)
jsx-runtime/dist/jsxRuntime.umd.js 966 B +32 B (+3.43%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 3.78 kB
compat/dist/compat.mjs 3.69 kB
compat/dist/compat.umd.js 3.83 kB
debug/dist/debug.js 3.85 kB
debug/dist/debug.mjs 3.85 kB
debug/dist/debug.umd.js 3.94 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.mjs 271 B
devtools/dist/devtools.umd.js 346 B
dist/preact.js 4.65 kB
dist/preact.mjs 4.66 kB
dist/preact.umd.js 4.72 kB
hooks/dist/hooks.js 1.52 kB
hooks/dist/hooks.mjs 1.54 kB
hooks/dist/hooks.umd.js 1.58 kB
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 473 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@marvinhagemeister marvinhagemeister merged commit 632d5cc into main Jun 11, 2025
14 checks passed
@marvinhagemeister marvinhagemeister deleted the precompile-signal-attr branch June 11, 2025 12:24
@JoviDeCroock JoviDeCroock mentioned this pull request Aug 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marvinhagemeister @JoviDeCroock