refactor (v11): Remove all export maps in nested pkg.json files #4784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschristian
changed the title
rschristian
force-pushed
the
refactor/remove-nested-export-maps
branch
from
b4435a4 to
c5f1f3d
Compare
JoviDeCroock
approved these changes
Jun 7, 2025
rschristian
force-pushed
the
refactor/remove-nested-export-maps
branch
from
c5f1f3d to
221c9b7
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were originally added in #3565 to support our use of
.module.jsas ESM in tools like Vite & Vitest (which incorrectly implement the top-level"module"spec) as they use a non-standard resolution mechanism which allows this to be a viable hack.This has become unnecessary in v11 though, we're exclusively using
.mjsfor ESM and so these serve no real purpose anymore. We could get rid of the nestedpackage.jsonfiles altogether and move the Microbundle config into the rootpackage.jsontoo if we wanted at some point, but I'll leave that for now.While I was at it I removed left-over
"script"&"version"entries (AFAICT"version"was never requested/needed by anyone, might've been copy/pasted in without much thought?) and re-ordered the keys to make the files consistent. Sorry for the OCD 😅