Move `defaultProps` into `preact/compat` #4657

JoviDeCroock · 2025-02-12T08:58:29Z

This will be handled in options.vnode for function/class components. This hook gets called for every invocation of jsx/createElement and cloneElement.

Not sure yet on how to fix the types for Context

github-actions · 2025-02-12T08:58:52Z

📊 Tachometer Benchmark Results

Summary

⏳ Benchmarks are currently running. Results below are out of date.

duration

create10k: unsure 🔍 -1% - +1% (-9.30ms - +5.30ms)
^{preact-local vs preact-main}
filter-list: unsure 🔍 -1% - +1% (-0.13ms - +0.22ms)
^{preact-local vs preact-main}
hydrate1k: unsure 🔍 -1% - +3% (-0.59ms - +2.00ms)
^{preact-local vs preact-main}
many-updates: unsure 🔍 -4% - +3% (-0.68ms - +0.50ms)
^{preact-local vs preact-main}
replace1k: unsure 🔍 -1% - +1% (-0.88ms - +0.80ms)
^{preact-local vs preact-main}
text-update: unsure 🔍 -4% - +5% (-0.08ms - +0.10ms)
^{preact-local vs preact-main}
todo: unsure 🔍 -2% - +1% (-0.86ms - +0.19ms)
^{preact-local vs preact-main}
update10th1k: unsure 🔍 -4% - +4% (-1.47ms - +1.43ms)
^{preact-local vs preact-main}

usedJSHeapSize

create10k: unsure 🔍 +0% - +0% (+0.02ms - +0.02ms)
^{preact-local vs preact-main}
filter-list: unsure 🔍 -0% - +2% (-0.00ms - +0.03ms)
^{preact-local vs preact-main}
hydrate1k: unsure 🔍 -5% - +3% (-0.51ms - +0.37ms)
^{preact-local vs preact-main}
many-updates: unsure 🔍 -0% - +1% (-0.01ms - +0.02ms)
^{preact-local vs preact-main}
replace1k: unsure 🔍 -1% - +1% (-0.02ms - +0.02ms)
^{preact-local vs preact-main}
text-update: faster ✔ 0% - 1% (0.00ms - 0.01ms)
^{preact-local vs preact-main}
todo: unsure 🔍 -1% - +1% (-0.01ms - +0.01ms)
^{preact-local vs preact-main}
update10th1k: faster ✔ 0% - 1% (0.01ms - 0.03ms)
^{preact-local vs preact-main}

Results

⏳ Benchmarks are currently running. Results below are out of date.

create10k

Browser: chrome-headless
Sample size: 50
Built by: CI #4331
Commit: 6c34c2b

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	939.43ms - 949.40ms	-	unsure 🔍 -1% - +1% -9.30ms - +5.30ms
preact-main	941.09ms - 951.75ms	unsure 🔍 -1% - +1% -5.30ms - +9.30ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	19.21ms - 19.22ms	-	unsure 🔍 +0% - +0% +0.02ms - +0.02ms
preact-main	19.20ms - 19.20ms	unsure 🔍 -0% - -0% -0.02ms - -0.02ms	-

filter-list

Browser: chrome-headless
Sample size: 50
Built by: CI #4331
Commit: 6c34c2b

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.50ms - 16.82ms	-	unsure 🔍 -1% - +1% -0.13ms - +0.22ms
preact-main	16.54ms - 16.68ms	unsure 🔍 -1% - +1% -0.22ms - +0.13ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.51ms - 1.54ms	-	unsure 🔍 -0% - +2% -0.00ms - +0.03ms
preact-main	1.50ms - 1.52ms	unsure 🔍 -2% - +0% -0.03ms - +0.00ms	-

hydrate1k

Browser: chrome-headless
Sample size: 50
Built by: CI #4331
Commit: 6c34c2b

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	76.68ms - 78.55ms	-	unsure 🔍 -1% - +3% -0.59ms - +2.00ms
preact-main	76.01ms - 77.81ms	unsure 🔍 -3% - +1% -2.00ms - +0.59ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	10.38ms - 10.94ms	-	unsure 🔍 -5% - +3% -0.51ms - +0.37ms
preact-main	10.39ms - 11.07ms	unsure 🔍 -4% - +5% -0.37ms - +0.51ms	-

many-updates

Browser: chrome-headless
Sample size: 50
Built by: CI #4331
Commit: 6c34c2b

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	17.19ms - 18.18ms	-	unsure 🔍 -4% - +3% -0.68ms - +0.50ms
preact-main	17.44ms - 18.11ms	unsure 🔍 -3% - +4% -0.50ms - +0.68ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.75ms - 3.78ms	-	unsure 🔍 -0% - +1% -0.01ms - +0.02ms
preact-main	3.75ms - 3.77ms	unsure 🔍 -1% - +0% -0.02ms - +0.01ms	-

replace1k

Browser: chrome-headless
Sample size: 100
Built by: CI #4331
Commit: 6c34c2b

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	65.01ms - 65.77ms	-	unsure 🔍 -1% - +1% -0.88ms - +0.80ms
preact-main	64.68ms - 66.19ms	unsure 🔍 -1% - +1% -0.80ms - +0.88ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.96ms - 3.00ms	-	unsure 🔍 -1% - +1% -0.02ms - +0.02ms
preact-main	2.97ms - 2.99ms	unsure 🔍 -1% - +1% -0.02ms - +0.02ms	-

run-warmup-0

Version	Avg time	vs preact-local	vs preact-main
preact-local	29.58ms - 30.14ms	-	unsure 🔍 -2% - +1% -0.53ms - +0.29ms
preact-main	29.69ms - 30.28ms	unsure 🔍 -1% - +2% -0.29ms - +0.53ms	-

run-warmup-1

Version	Avg time	vs preact-local	vs preact-main
preact-local	33.56ms - 34.57ms	-	unsure 🔍 -1% - +2% -0.46ms - +0.83ms
preact-main	33.48ms - 34.27ms	unsure 🔍 -2% - +1% -0.83ms - +0.46ms	-

run-warmup-2

Version	Avg time	vs preact-local	vs preact-main
preact-local	25.75ms - 26.13ms	-	unsure 🔍 -2% - +1% -0.53ms - +0.17ms
preact-main	25.83ms - 26.42ms	unsure 🔍 -1% - +2% -0.17ms - +0.53ms	-

run-warmup-3

Version	Avg time	vs preact-local	vs preact-main
preact-local	26.48ms - 27.61ms	-	unsure 🔍 -0% - +6% +0.01ms - +1.63ms
preact-main	25.64ms - 26.81ms	faster ✔ 0% - 6% 0.01ms - 1.63ms	-

run-warmup-4

Version	Avg time	vs preact-local	vs preact-main
preact-local	24.85ms - 26.23ms	-	unsure 🔍 -4% - +3% -1.04ms - +0.80ms
preact-main	25.05ms - 26.27ms	unsure 🔍 -3% - +4% -0.80ms - +1.04ms	-

run-final

Version	Avg time	vs preact-local	vs preact-main
preact-local	20.60ms - 21.00ms	-	unsure 🔍 -2% - +2% -0.33ms - +0.42ms
preact-main	20.43ms - 21.07ms	unsure 🔍 -2% - +2% -0.42ms - +0.33ms	-

text-update

Browser: chrome-headless
Sample size: 140
Built by: CI #4331
Commit: 6c34c2b

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.03ms - 2.18ms	-	unsure 🔍 -4% - +5% -0.08ms - +0.10ms
preact-main	2.04ms - 2.14ms	unsure 🔍 -5% - +4% -0.10ms - +0.08ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.10ms - 1.11ms	-	faster ✔ 0% - 1% 0.00ms - 0.01ms
preact-main	1.11ms - 1.11ms	slower ❌ 0% - 1% 0.00ms - 0.01ms	-

todo

Browser: chrome-headless
Sample size: 50
Built by: CI #4331
Commit: 6c34c2b

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	33.51ms - 34.23ms	-	unsure 🔍 -2% - +1% -0.86ms - +0.19ms
preact-main	33.82ms - 34.58ms	unsure 🔍 -1% - +3% -0.19ms - +0.86ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.21ms - 1.23ms	-	unsure 🔍 -1% - +1% -0.01ms - +0.01ms
preact-main	1.21ms - 1.22ms	unsure 🔍 -1% - +1% -0.01ms - +0.01ms	-

update10th1k

Browser: chrome-headless
Sample size: 50
Built by: CI #4331
Commit: 6c34c2b

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	33.49ms - 35.78ms	-	unsure 🔍 -4% - +4% -1.47ms - +1.43ms
preact-main	33.77ms - 35.54ms	unsure 🔍 -4% - +4% -1.43ms - +1.47ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.90ms - 2.91ms	-	faster ✔ 0% - 1% 0.01ms - 0.03ms
preact-main	2.91ms - 2.94ms	slower ❌ 0% - 1% 0.01ms - 0.03ms	-

_{tachometer-reporter-action v2 for CI}

github-actions · 2025-02-12T08:59:47Z

Size Change: 0 B

Total Size: 60.6 kB

ℹ️ View Unchanged

Filename	Size
`compat/dist/compat.js`	3.75 kB
`compat/dist/compat.module.js`	3.67 kB
`compat/dist/compat.umd.js`	3.81 kB
`debug/dist/debug.js`	3.87 kB
`debug/dist/debug.module.js`	3.87 kB
`debug/dist/debug.umd.js`	3.95 kB
`devtools/dist/devtools.js`	260 B
`devtools/dist/devtools.module.js`	274 B
`devtools/dist/devtools.umd.js`	346 B
`dist/preact.js`	4.56 kB
`dist/preact.min.js`	4.6 kB
`dist/preact.min.module.js`	4.59 kB
`dist/preact.min.umd.js`	4.63 kB
`dist/preact.module.js`	4.59 kB
`dist/preact.umd.js`	4.65 kB
`hooks/dist/hooks.js`	1.54 kB
`hooks/dist/hooks.module.js`	1.57 kB
`hooks/dist/hooks.umd.js`	1.61 kB
`jsx-runtime/dist/jsxRuntime.js`	957 B
`jsx-runtime/dist/jsxRuntime.module.js`	926 B
`jsx-runtime/dist/jsxRuntime.umd.js`	1.03 kB
`test-utils/dist/testUtils.js`	473 B
`test-utils/dist/testUtils.module.js`	477 B
`test-utils/dist/testUtils.umd.js`	555 B

_{compressed-size-action}

This will be handled in `options.vnode` for function/class components. This hook gets called for every invocation of `jsx`/`createElement` and `cloneElement`.

rschristian · 2025-02-13T11:47:39Z

Still playing around with it, but I think we want something starting like this:

declare module 'preact' {
	export interface FunctionComponent<P = {}> {
		(props: preact.RenderableProps<P>, context?: any): preact.ComponentChildren;
		displayName?: string;
		defaultProps?: Partial<P> | undefined;
	}

	export interface ComponentClass<P = {}, S = {}> {
		new (props: P, context?: any): preact.Component<P, S>;
		displayName?: string;
		defaultProps?: Partial<P>;
		contextType?: preact.Context<any>;
		getDerivedStateFromProps?(
			props: Readonly<P>,
			state: Readonly<S>
		): Partial<S> | null;
		getDerivedStateFromError?(error: any): Partial<S> | null;
	}
}

The problem is the abstract class Component, which, as far as I can tell, cannot be merged. I don't yet know how to work around that

* Move `defaultProps` into `preact/compat` This will be handled in `options.vnode` for function/class components. This hook gets called for every invocation of `jsx`/`createElement` and `cloneElement`. * Try it * refactor: This is horrific but seems to work? (#4662) --------- Co-authored-by: Ryan Christian <[email protected]>

JoviDeCroock mentioned this pull request Feb 12, 2025

(major) - Tracking PR for v11 #4549

Merged

1 task

JoviDeCroock force-pushed the remove-defaultprops branch 3 times, most recently from 434b77f to 8a2371a Compare February 13, 2025 10:31

Move defaultProps into preact/compat

ebe4e53

This will be handled in `options.vnode` for function/class components. This hook gets called for every invocation of `jsx`/`createElement` and `cloneElement`.

JoviDeCroock force-pushed the remove-defaultprops branch 3 times, most recently from 9c77efe to 6ee3c04 Compare February 13, 2025 11:16

JoviDeCroock requested a review from rschristian February 13, 2025 11:16

Try it

6ee3c04

refactor: This is horrific but seems to work? (#4662)

5abf2e5

JoviDeCroock merged commit c4ed4f4 into v11-2 Feb 13, 2025
3 checks passed

JoviDeCroock deleted the remove-defaultprops branch February 13, 2025 12:08

JoviDeCroock mentioned this pull request Aug 19, 2025

v11.0.0-beta.0 #4893

Merged

Uh oh!

Move defaultProps into preact/compat #4657

Move defaultProps into preact/compat #4657

Uh oh!

Conversation

JoviDeCroock commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

duration

usedJSHeapSize

Results

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

run-warmup-0

run-warmup-1

run-warmup-2

run-warmup-3

run-warmup-4

run-final

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

Uh oh!

github-actions bot commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rschristian commented Feb 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Move `defaultProps` into `preact/compat` #4657

Move `defaultProps` into `preact/compat` #4657

JoviDeCroock commented Feb 12, 2025 •

edited

Loading

github-actions bot commented Feb 12, 2025 •

edited

Loading

github-actions bot commented Feb 12, 2025 •

edited

Loading